From owner-freebsd-current  Mon May  5 19:44:03 1997
Return-Path: <owner-current>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id TAA08637
          for current-outgoing; Mon, 5 May 1997 19:44:03 -0700 (PDT)
Received: from cheops.anu.edu.au (avalon@cheops.anu.edu.au [150.203.76.24])
          by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id TAA08597;
          Mon, 5 May 1997 19:43:53 -0700 (PDT)
Message-Id: <199705060243.TAA08597@hub.freebsd.org>
Received: by cheops.anu.edu.au
	(1.37.109.16/16.2) id AA176396505; Tue, 6 May 1997 12:41:45 +1000
From: Darren Reed <avalon@coombs.anu.edu.au>
Subject: Re: divert still broken?
To: archie@whistle.com (Archie Cobbs)
Date: Tue, 6 May 1997 12:41:45 +1000 (EST)
Cc: avalon@coombs.anu.edu.au, nnd@info.itfs.nsk.su, current@freebsd.org,
        hackers@freebsd.org
In-Reply-To: <199705060044.RAA10251@bubba.whistle.com> from "Archie Cobbs" at May 5, 97 05:44:52 pm
X-Mailer: ELM [version 2.4 PL23]
Content-Type: text
Sender: owner-current@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

In some mail from Archie Cobbs, sie said:
> 
> 
> > >  - Simplify the ip_fw_chk() function call interface
> > 
> > well, the list of things which you must pass are:
> > * pointer to a pointer to an mbuf (ip_fw_chk() may want to modify it - e.g.
> > 	  calls m_pullup)
> 
> Keeping this...
> 
> > * interface (m_rcvif is often NULL in ip_output, besides which setting it
> > 	     in ip_output is semantically incorrect)
> > * value indicating whether it is being called from ip_input or ip_output
> 
> Changing this.. m_rcvif is NULL if-and-only-if there is no receive
> interface associated with the packet. Also, you'll noticed that
> the call from ip_input() just sets this parameter to m_rcvif from
> the packet. So these two arguments are being replaced by a single
> argument with is the output interface... which is NULL if-and-only-if
> the direction of the packet is incoming.
> 
> > - that's the *must have* list.  Convienience parameters are:
> > * pointer to the IP header
> > * precomputed real IP header length (from ip_hl)
> 
> Keeping...

Sounds ok