From owner-cvs-all Sun Nov 15 05:54:28 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id FAA26766 for cvs-all-outgoing; Sun, 15 Nov 1998 05:54:28 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA26761; Sun, 15 Nov 1998 05:54:27 -0800 (PST) (envelope-from bde@FreeBSD.org) From: Bruce Evans Received: (from bde@localhost) by freefall.freebsd.org (8.8.8/8.8.5) id FAA20777; Sun, 15 Nov 1998 05:54:31 -0800 (PST) Date: Sun, 15 Nov 1998 05:54:31 -0800 (PST) Message-Id: <199811151354.FAA20777@freefall.freebsd.org> To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: cvs commit: src/sys/i386/isa wd.c Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk bde 1998/11/15 05:54:31 PST Modified files: sys/i386/isa wd.c Log: Fixed the bug that caused negative busycounts in devstat. The devstart_start_transaction() call is misplaced - it is after the wdustart() call that queues the transaction on the controller queue. Normally this doesn't matter because we're running at splbio() so nothing will look at the controller queue. However, obsolescent code for syncing labels sometimes slept after the transaction was started, so the transaction sometimes completed before it was [recorded as] started. This code was misplaced even for syncing labels. Move it to the right place. It should go away, but something may depend on its side effects. Revision Changes Path 1.179 +6 -6 src/sys/i386/isa/wd.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message