From owner-freebsd-current@FreeBSD.ORG Sun Jul 20 15:48:44 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BCDC837B404; Sun, 20 Jul 2003 15:48:44 -0700 (PDT) Received: from mailout.informatik.tu-muenchen.de (mailout.informatik.tu-muenchen.de [131.159.0.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1B26B43F85; Sun, 20 Jul 2003 15:48:43 -0700 (PDT) (envelope-from barner@in.tum.de) Received: by zi025.glhnet.mhn.de (Postfix, from userid 1000) id D2089387CA; Mon, 21 Jul 2003 00:48:40 +0200 (CEST) Date: Mon, 21 Jul 2003 00:48:40 +0200 From: Simon Barner To: "Jacques A. Vidrine" Message-ID: <20030720224840.GA731@zi025.glhnet.mhn.de> References: <20030718025200.GA36893@rot13.obsecurity.org> <20030719030539.GB467@zi025.glhnet.mhn.de> <20030719190500.GA19808@hellblazer.celabo.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="i9LlY+UWpKt15+FH" Content-Disposition: inline In-Reply-To: <20030719190500.GA19808@hellblazer.celabo.org> User-Agent: Mutt/1.5.4i X-Virus-Scanned: by amavisd-new at informatik.tu-muenchen.de cc: ports@FreeBSD.org cc: current@FreeBSD.org cc: Kris Kennaway Subject: Re: Fixing gcc 3.3 compile failures -- fix for math/freefem X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2003 22:48:45 -0000 --i9LlY+UWpKt15+FH Content-Type: multipart/mixed; boundary="sdtB3X0nJg68CQEu" Content-Disposition: inline --sdtB3X0nJg68CQEu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, > > - ifstream fin( path ); > > + std::ifstream fin( path ); > A much smaller patch could be produced with >=20 > using namespace std; >=20 > as appropriate. >=20 > Have you checked with the upstream author to see which approach is > likely to be rolled into the distribution? Actually, upgrading the port to the lastest freefem version would have been enough *doh* :o) (patch attached) To answer your question: the freefem authors decided not to use the 'using namespace std' approach. Cheers, Simon --sdtB3X0nJg68CQEu Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="freefem-port.patch" Content-Transfer-Encoding: quoted-printable --- Makefile.orig Thu Jun 5 01:41:14 2003 +++ Makefile Mon Jul 21 00:42:53 2003 @@ -6,7 +6,7 @@ # =20 PORTNAME=3D freefem -PORTVERSION=3D 3.5.4 +PORTVERSION=3D 3.5.7 CATEGORIES=3D math cad MASTER_SITES=3D ${MASTER_SITE_SOURCEFORGE} MASTER_SITE_SUBDIR=3D kfem @@ -24,10 +24,6 @@ MAN1=3D freefem.1 =20 .include - -.if ${OSVERSION} >=3D 500113 -BROKEN=3D "Does not compile (bad C++ code)" -.endif =20 post-patch: @${REINPLACE_CMD} -e 's|-O3 |\$$CXXFLAGS |g' ${WRKSRC}/configure --- distinfo.orig Tue Mar 26 17:04:16 2002 +++ distinfo Mon Jul 21 00:38:13 2003 @@ -1 +1 @@ -MD5 (freefem-3.5.4.tar.gz) =3D 746fe6487085011493a805e23507ae30 +MD5 (freefem-3.5.7.tar.gz) =3D e8f22515ab56f8e79fb789a11f8d4bef --sdtB3X0nJg68CQEu-- --i9LlY+UWpKt15+FH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (FreeBSD) iD8DBQE/GxxICkn+/eutqCoRAvk2AJ4hoJ86tk2/xnomQEVIMSc1/t01IgCfaK6f nBZKFXCU1nIAfGZN4kf+vds= =RH6x -----END PGP SIGNATURE----- --i9LlY+UWpKt15+FH--