From owner-svn-src-stable-10@FreeBSD.ORG Tue Jan 27 02:36:21 2015 Return-Path: Delivered-To: svn-src-stable-10@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 176D96D4; Tue, 27 Jan 2015 02:36:21 +0000 (UTC) Received: from mail-pd0-x233.google.com (mail-pd0-x233.google.com [IPv6:2607:f8b0:400e:c02::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DA93FAAC; Tue, 27 Jan 2015 02:36:20 +0000 (UTC) Received: by mail-pd0-f179.google.com with SMTP id v10so15851927pde.10; Mon, 26 Jan 2015 18:36:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=t2Ltt5lZX90ZQ1jFUheTPG8kBq0+U4ypXpHZ4NN6z68=; b=G0S5lmD08ZxQ8tZ2d11ZvHsZNmAPYwXtHWcR5WBK1loRt1wLDHK1KLQnSIyDvmKHhQ 6mLC/hbHBd0Ev5IszXf2PKDoELacgAV9FReqJoLBxIAIQHIUf2FVA7eh59GnNCwBHEBC /FNM79aPL2rYRJgUaG0FCP2Ok+mMhYffFKz5Ve/e61Uhr7RyCrCsHP7O2EPQKrtnBzQo JauBGy0nCEwbjzeEuCIsyavGIYJXWDMsYcLWT15tDhSCCLIfIanEcX9pzvkt4dg7eT6t EdDxez4zBaxaZB70Ku4pabUCSZhVngTnTQjoHEf2Kjno0ME6SiUxBViozy5wpMaHUJK6 phlA== X-Received: by 10.66.119.193 with SMTP id kw1mr40062542pab.64.1422326180326; Mon, 26 Jan 2015 18:36:20 -0800 (PST) Received: from ?IPv6:2601:8:ab80:7d6:bc82:b31b:4ccc:789f? ([2601:8:ab80:7d6:bc82:b31b:4ccc:789f]) by mx.google.com with ESMTPSA id 9sm10954163pdg.38.2015.01.26.18.36.18 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 26 Jan 2015 18:36:19 -0800 (PST) Content-Type: multipart/signed; boundary="Apple-Mail=_65845936-61F9-4FBF-97F3-D715BF39BA7C"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r276423 - stable/10/share/mk From: Garrett Cooper In-Reply-To: Date: Mon, 26 Jan 2015 18:36:19 -0800 Message-Id: <96750137-123C-4D51-9EC7-8269D9463AC1@gmail.com> References: <201412302046.sBUKk2B3049040@svn.freebsd.org> To: Julio Merino X-Mailer: Apple Mail (2.1878.6) Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-10@freebsd.org, Garrett Cooper X-BeenThere: svn-src-stable-10@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for only the 10-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jan 2015 02:36:21 -0000 --Apple-Mail=_65845936-61F9-4FBF-97F3-D715BF39BA7C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Dec 31, 2014, at 7:54, Julio Merino wrote: > On Dec 30, 2014, at 21:46, Garrett Cooper wrote: >=20 >> Author: ngie >> Date: Tue Dec 30 20:46:01 2014 >> New Revision: 276423 >> URL: https://svnweb.freebsd.org/changeset/base/276423 >>=20 >> Log: >> MFC r274077: >>=20 >> As an optimization (in simple, well used cases) only call cat = ${.ALLSRC} when >> generating files from various sources instead of calling cat = ${.ALLSRC} | sed >=20 > Is there any visible effect to this optimization? Otherwise, the = extra complexity does not seem warranted. Hi Julio! There are a few things to gain from this: 1. Errors with cat=92ing the files are caught when sed transformations = aren=92t applied to the files. 2. Less resources are used in generating the files if sed isn=92t = needed: i. Less forked processes. ii. No pipelines need to be created. I don=92t have numbers for how much faster it is (probably negligible if = done once, potentially more noticeable if done as a micro benchmark), = but I could do this if you like. Thank you! --Apple-Mail=_65845936-61F9-4FBF-97F3-D715BF39BA7C Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUxvmjAAoJEMZr5QU6S73euhgH/3VMnKcSOdxtv81nTd78ZfQz 7v5O7dYr0h+kvmXyJoas+NUdrRKp999TK3sUI12lBu2Z2FOZuTS3BWLG11sulq7R H8i1G1GWBXAuWHArvllbgXmeeuVQF9B2gTNtfsG6WjK5KdD+I2z8jtBtJJlP+x3r Y3/FDZ2yFefpBg/6qs4nSnkcSeyPkLZcQoHzmc/X2HiedAPCFzYuhHdsk2NJQTWc 3flH7ielCZpLO+cygULnPv9ZPsZouLwIulaQKhlq7o1mk4DPXCIWkGB5uZiwZqaL CWbyiKDw0TlobYzTI3iMyYVnr8kkXbUUNSlJ/glE0ZSrDbhGNv6i881EOxuKauo= =1JLW -----END PGP SIGNATURE----- --Apple-Mail=_65845936-61F9-4FBF-97F3-D715BF39BA7C--