Date: Sun, 2 Jan 2000 16:10:33 -0500 (EST) From: brdean@mindspring.com To: FreeBSD-gnats-submit@freebsd.org Subject: bin/15848: tip core dumps after transferring a file from local to remote Message-ID: <200001022110.QAA30819@vger.foo.com>
next in thread | raw e-mail | index | archive | help
>Number: 15848
>Category: bin
>Synopsis: tip core dumps after transferring a file from local to remote
>Confidential: no
>Severity: serious
>Priority: high
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Jan 2 13:20:00 PST 2000
>Closed-Date:
>Last-Modified:
>Originator: Brian Scott Dean
>Release: FreeBSD 4.0-CURRENT i386
>Organization:
>Environment:
FreeBSD vger.foo.com 4.0-CURRENT FreeBSD 4.0-CURRENT #0: Wed Dec 29 23:30:55 EST 1999 bsd@vger.foo.com:/usr/src/sys/compile/VGER i386
Current sources as of December 23, 1999
>Description:
tip core dumps after transferring a file from local to remote
when no eof characters have been specified. The core dump is
due to a NULL pointer dereference.
>How-To-Repeat:
1) Use tip to connect to a remote system
2) Set the remote system to receive a file
3) Use the tip ~> command to initiate a file transfer
4) Enter a local filename to transfer
>Fix:
cvs diff: Diffing .
Index: cmds.c
===================================================================
RCS file: /usr02/mirror/ncvs/src/usr.bin/tip/tip/cmds.c,v
retrieving revision 1.10
diff -u -r1.10 cmds.c
--- cmds.c 1999/08/28 01:06:32 1.10
+++ cmds.c 2000/01/02 20:46:56
@@ -513,7 +513,7 @@
out:
if (lastc != '\n' && !boolean(value(RAWFTP)))
send('\r');
- for (pc = eofchars; *pc; pc++)
+ for (pc = eofchars; pc && *pc; pc++)
send(*pc);
stop_t = time(0);
fclose(fd);
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200001022110.QAA30819>