From owner-freebsd-stable@FreeBSD.ORG Mon Mar 19 02:20:39 2012 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5F0F3106564A for ; Mon, 19 Mar 2012 02:20:39 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from mail-pz0-f54.google.com (mail-pz0-f54.google.com [209.85.210.54]) by mx1.freebsd.org (Postfix) with ESMTP id 2D4678FC17 for ; Mon, 19 Mar 2012 02:20:38 +0000 (UTC) Received: by dald2 with SMTP id d2so9829047dal.13 for ; Sun, 18 Mar 2012 19:20:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=HJo45CwYzk2rACUO/XTmygDhqHkdAv4aXW7aV6Ubqk0=; b=1C47swghnQC4R5ccmAcgir7ohMJO9QPloGA91WRmrLuCoEX4xRoaijq/VjAPqXxjQa pYoxX1UQM8TqliOBltnrKEXRGidNdeLrJxpIMsu2Wer3XRqLHDV1znWn6KCEpQXFQ5Yg 6wjEYY+a7ychlvAZSK5zcCXBb18MtR+R0Idj2utbwHaJWN8Fh4qutQ0KE57OXzU5BDh6 A3RnofRYpm8o2+iRZ6nFYT+OTIxoSegxZSo5/QXyzUFfvQdc/JwTThtOu5prrwORoYHu TOVEsxhjXQGYB3ohRC6G8A6sx1pRdTEShkFzD9nKZ72j0XIRi2UpWdk+Qo/FtxWCnKRa ZBwA== Received: by 10.68.241.226 with SMTP id wl2mr30380640pbc.139.1332123638756; Sun, 18 Mar 2012 19:20:38 -0700 (PDT) Received: from pyunyh@gmail.com ([114.111.62.249]) by mx.google.com with ESMTPS id j3sm10143189pbb.29.2012.03.18.19.20.36 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 18 Mar 2012 19:20:38 -0700 (PDT) Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Mon, 19 Mar 2012 11:20:32 -0700 From: YongHyeon PYUN Date: Mon, 19 Mar 2012 11:20:32 -0700 To: Mike Tancsa Message-ID: <20120319182032.GA7518@michelle.cdnetworks.com> References: <4F63A772.30406@sentex.net> <20120317225858.GA1660@michelle.cdnetworks.com> <4F65401B.303@sentex.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F65401B.303@sentex.net> User-Agent: Mutt/1.4.2.3i Cc: FreeBSD-STABLE Mailing List Subject: Re: fxp entering promiscuous mode causing link to bounce X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Mar 2012 02:20:39 -0000 On Sat, Mar 17, 2012 at 09:53:31PM -0400, Mike Tancsa wrote: > On 3/17/2012 6:58 PM, YongHyeon PYUN wrote: > > On Fri, Mar 16, 2012 at 04:49:54PM -0400, Mike Tancsa wrote: > >> > >> tcpdump -ni fxp0 -c 20 > >> > >> fxp0: link state changed to DOWN > >> fxp0: promiscuous mode enabled > >> fxp0: link state changed to UP > >> fxp0: link state changed to DOWN > >> fxp0: promiscuous mode disabled > >> fxp0: link state changed to UP > >> > >> I verified it on 2 different boxes. Is there a way to prevent this from happening ? > >> > > > > It looks like a regression introduced in flow control support. > > > Thanks very much, that indeed did fix it!! > > > 0(smtp1)# patch < fxp.p > Hmm... Looks like a unified diff to me... > The text leading up to this was: > -------------------------- > |Index: sys/dev/fxp/if_fxp.c > |=================================================================== > |--- sys/dev/fxp/if_fxp.c (revision 233076) > |+++ sys/dev/fxp/if_fxp.c (working copy) > -------------------------- > Patching file sys/dev/fxp/if_fxp.c using Plan A... > Hunk #1 succeeded at 900 (offset -2 lines). > Hunk #2 succeeded at 2808 (offset -2 lines). > Hunk #3 succeeded at 2914 (offset -2 lines). > > > fxp0: promiscuous mode enabled > fxp0: promiscuous mode disabled > > ... and not bounced link/dropped packets. Thanks for testing. Committed in r233158. fxp(4) controllers require controller reinitialization for promiscuous mode change so it's normal to miss packets during that transition. fxp(4) controllers have many limitation and this is one of them.