From owner-cvs-all@FreeBSD.ORG  Fri Aug 17 08:57:23 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BFD8516A4AB;
	Fri, 17 Aug 2007 08:57:23 +0000 (UTC) (envelope-from des@des.no)
Received: from tim.des.no (tim.des.no [194.63.250.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 692B413C48E;
	Fri, 17 Aug 2007 08:57:23 +0000 (UTC) (envelope-from des@des.no)
Received: from tim.des.no (localhost [127.0.0.1])
	by spam.des.no (Postfix) with ESMTP id F023520B0;
	Fri, 17 Aug 2007 10:57:18 +0200 (CEST)
X-Spam-Tests: AWL
X-Spam-Learn: disabled
X-Spam-Score: 0.0/3.0
X-Spam-Checker-Version: SpamAssassin 3.2.1 (2007-05-02) on tim.des.no
Received: from ds4.des.no (des.no [80.203.243.180])
	by smtp.des.no (Postfix) with ESMTP id 65236208A;
	Fri, 17 Aug 2007 10:57:18 +0200 (CEST)
Received: by ds4.des.no (Postfix, from userid 1001)
	id 296D084437; Fri, 17 Aug 2007 10:57:18 +0200 (CEST)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Mike Makonnen <mtm@FreeBSD.org>
References: <200708170758.l7H7wRbV097007@repoman.freebsd.org>
Date: Fri, 17 Aug 2007 10:57:17 +0200
In-Reply-To: <200708170758.l7H7wRbV097007@repoman.freebsd.org> (Mike
	Makonnen's message of "Fri\, 17 Aug 2007 07\:58\:27 +0000 \(UTC\)")
Message-ID: <86vebeiln6.fsf@ds4.des.no>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/etc/rc.d Makefile lockd nfslocking statd
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Aug 2007 08:57:23 -0000

Mike Makonnen <mtm@FreeBSD.org> writes:
>   Log:
>   The rc.d/nfslocking file controls two servers: rpc.statd and rpc.lockd.=
 It worked well
>   in most cases, except one. The 'restart' case was not working as expect=
ed. Specifically,
>   it would stop both lockd and statd, but it would restart only statd (wh=
ich appears first
>   in the script). This is because rc.subr(8) contains code to guard again=
st infinite
>   recursion in the 'restart' casae.
>=20=20=20
>   To fix this use the traditional approach of controlling only one server=
 from one script by
>   breaking out rc.d/nfslocking into its contituent parts: rc.d/lockd and =
rc.d/statd. Keep
>   rc.d/nfslocking around but don't include it in the boot rcorder(8)ing.

Wouldn't it have been better to name them rpc_lockd and rpc_statd, to
match their rc.conf variables?

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no