From owner-svn-ports-all@freebsd.org Tue Jun 19 11:36:05 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CA9F41012FA1; Tue, 19 Jun 2018 11:36:05 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7DA6C7BB7B; Tue, 19 Jun 2018 11:36:05 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from ogg.in.absolight.net (ogg.in.absolight.net [IPv6:2a01:678:ab:50::42:42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id C2A861BE0C; Tue, 19 Jun 2018 11:36:04 +0000 (UTC) (envelope-from mat@FreeBSD.org) Date: Tue, 19 Jun 2018 13:36:01 +0200 From: Mathieu Arnold To: Carlos Jacobo Puga Medina Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r472498 - head/archivers/py-borgbackup Message-ID: <20180619113601.socvt425uqii4wrj@ogg.in.absolight.net> References: <201806152206.w5FM6dup090058@repo.freebsd.org> <20180618202251.5p2uvx6vc2bwgjx4@atuin.in.mat.cc> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uhpu5o64lu7g5cir" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jun 2018 11:36:06 -0000 --uhpu5o64lu7g5cir Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 18, 2018 at 10:26:42PM +0200, Carlos Jacobo Puga Medina wrote: > > Enviar: lunes 18 de junio de 2018 a las 22:22 > > De: "Mathieu Arnold" > > Para: "Carlos J. Puga Medina" > > CC:=20 > > Asunto: Re: svn commit: r472498 - head/archivers/py-borgbackup > > > > On Fri, Jun 15, 2018 at 10:06:39PM +0000, Carlos J. Puga Medina wrote: > > > - Enable FUSE option by default > >=20 > > Why? > > >=20 > The port maintainer requested this change. I'm missing something? Commit messages are the place where you explain WHY you are doing things. Rewriting the diff in plain English only adds noise and should be avoided. The maintainer is the main caretaker of the port yes, but the maintainer is not the only caretaker. The port is maintained by the community. And as such, the community needs to be able to remember, as a collective why changes are made. To be able to achieve this, writing WHY changes are made in the commit messages is paramount. Now, nobody has any idea why the option changed to default on, maybe it is because the port is mostly useless without it, or because user may need it, or because the maintainer decided he wanted to change something else in the Makefile so that it looked more real. --=20 Mathieu Arnold --uhpu5o64lu7g5cir Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAABCgBmBQJbKOqhXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IQlsQAI6oxu/jUBInIq6b3yKZItQy /c43js9x+v6ZW7thsQL2QiWDU/x4364kmDf7vdBlAyYz8CPHpZURhJhd6/nxNQXk rTqg5uf2puZvNWHN7apt+s9vGt0BmvxAUHWkHb3d6vnL5+HAh/dAlqSm42gZ7iGh wIor5iWe+aPvYq1SROxZx+tok+HqvO25f+Nj9Dw5gFleJYgUlu2L7+fNG6XF1cbQ Bj0zOPIHG588WYtRSOWtTMAx6AEjF5/FH5ZmHb7zAsmb+Ys/fyasXC0F+e8SfZY2 6/89NbrKO0jZkeI1hnQn3bmECFoi9XTo3rYQSivY/tUYhlZXVlvRHlM5r+mw9Sbr jPo0GL87MmRSa/W9/lRtoV34Yoc8KW1rOBgIAW9f87K1Q0qMckXOOvtfA6W4sQcr yvdOMQM50hYd421vxxYuHi5NdkH5k5qQvoXiUD1hSuYNiRWwuprPmXW6YuBGuvD4 Kzwxxrs7tw1izZKHfQq/ohIMTTWTRK6IESm6BUa8IDLD4T68twVbWzwUAf6yuL/J GQja3qU6jYVOTkFBVLLV9RTvKnWZF8Kg5tC/2EoVmAnWG164PBdpT7dggmAVOAWG 730lgOUHRONmqroUzsbJ75obuX9Hkt3LIL6lEP3ESrUtzQm4zkLsASX3cITsvurA aqExX1UVPadXxkOKC5zN =5yQp -----END PGP SIGNATURE----- --uhpu5o64lu7g5cir--