From owner-svn-src-all@freebsd.org Wed Sep 18 13:54:06 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 219E6FE177 for ; Wed, 18 Sep 2019 13:54:06 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46YM0F2PNvz4LVH for ; Wed, 18 Sep 2019 13:54:05 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x72c.google.com with SMTP id 4so8092819qki.6 for ; Wed, 18 Sep 2019 06:54:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XRwikxn5g6EWbzXQ61TZKQtamW1pm5X3cmdP9+6sIPc=; b=Q/dp0/4nJg5sdqe46wGn1uMCllIoUpd/VWZD0PQ4eKTQUP3LBTCxV5heflulT838+v b4FZuVh6JqUCRRiNAjUQBCADBq8WKmdH7kgfB5gdnrKmqYfOW09tK4/OP8nOXmP9RfqN OoS7kaskAtBEDQlctufYDSqV9FDRU8H7oYMshQMc34kBqcd+gsBL14A/CtwB1XVe/KfD cG8ykfSwhFy2IVZa6s82RyrteLowcTSOOeGtB2g8OoJqKIvWm1CMVFdmXBAZF6HIteOW UjRMlrRTrYH5LhdZS6xYHuVEcSRydmQy5Z7l72H3MzE80cQXYCTYKosO9cZ0f3bTMUzw Ap8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XRwikxn5g6EWbzXQ61TZKQtamW1pm5X3cmdP9+6sIPc=; b=Bkpos3+bS7gegrMNpopxopWZF0kod9oCEBGr00JrZxEzMp5/Wf4/JOMl4wwDhgxKN8 kuT0IoqBqBQVb0VYVksFOWwtd4lD1aa/fDVuzHdYCPyC/Oo2iKQQv2pGRoFEsjAdBDnC 9SNYmb7FvlaYKv0JU+zGtSuaKRz0aCaiz2YnxnNFYmAaa9nxZQP13LXA8+RYfAbbP6sJ 4wFqJv08xCL3cFB1MRV1doL5h4yvBfIoqRfGDbZijGds63R7pvZBuiKM9kHPPUf/zfDF coXexZGw2FomadHTOk91pJrlyOeiFUIV9VucJ5DdcsHrrQDmRg4xV1TgVFu1g2Ek3xiQ PcAg== X-Gm-Message-State: APjAAAV4wmb/UG2bFRMxgejOzOZDMcKwTkZ8Xo8vaPV67LWh0E3/y7wy C1kaqIgcgkAwy0ujinuddYXFGoroQ/Kg8+AdZP+p93atXD4= X-Google-Smtp-Source: APXvYqzapiM7f4Qn+WdIepd/VJUDO4hSWsPdsk4CY5Q31sgS2kB8DylUMnUrAZ9YHfe44XdfqylZBRZNxlrhd20vssM= X-Received: by 2002:a37:30f:: with SMTP id 15mr3705071qkd.240.1568814844116; Wed, 18 Sep 2019 06:54:04 -0700 (PDT) MIME-Version: 1.0 References: <201909180158.x8I1wuZu011258@repo.freebsd.org> <0FBC9A62-AE3B-4F27-AABC-06FF45F415F1@gmail.com> In-Reply-To: From: Warner Losh Date: Wed, 18 Sep 2019 14:53:49 +0100 Message-ID: Subject: Re: svn commit: r352465 - head/share/mk To: Kyle Evans Cc: Garrett Cooper , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 46YM0F2PNvz4LVH X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=Q/dp0/4n; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::72c) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.85 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[3]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[c.2.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.86)[ip: (-9.31), ipnet: 2607:f8b0::/32(-2.68), asn: 15169(-2.23), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; FREEMAIL_CC(0.00)[gmail.com] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 13:54:06 -0000 On Wed, Sep 18, 2019, 1:41 PM Kyle Evans wrote: > On Wed, Sep 18, 2019 at 7:34 AM Enji Cooper wrote: > > > > > > > On Sep 17, 2019, at 18:58, Kyle Evans wrote: > > > > > > Author: kevans > > > Date: Wed Sep 18 01:58:56 2019 > > > New Revision: 352465 > > > URL: https://svnweb.freebsd.org/changeset/base/352465 > > > > > > Log: > > > googletest: default-disable on all of MIPS for now > > > > > > Parts of the fusefs tests trigger a bug in current versions of llvm: > IR > > > representation of some routine for the MIPS targets is a function > with a > > > large number of arguments. This then leads the compiler on an hour+ > long > > > goose chase, which is OK if you build the current tree but less-so if > you're > > > trying external toolchain or doing a universe build involving mips > when it > > > eventually gets switched over to LLVM. > > > > > > Better, accurate details can be found in LLVM PR43263. > > > > Uhhhhh... why not do this in tests/sys/... instead? > > Because there's still value in being able to easily enable these for > building/running the complete set of tests through standard build > infrastructure, but it's not worth adding a knob specifically for the > fusefs tests. I also prefer the communication of it being an > off-by-default option and easily deduced from src.conf(5) that this > part of the build is default-disabled on mips/mips. > This is the right way to do this, imho... Warner >