From owner-freebsd-bugs@FreeBSD.ORG Sun Dec 4 10:13:57 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3BB161065675 for ; Sun, 4 Dec 2011 10:13:57 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 061578FC13 for ; Sun, 4 Dec 2011 10:13:57 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pB4ADuSs065182 for ; Sun, 4 Dec 2011 10:13:56 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pB4ADudb065181; Sun, 4 Dec 2011 10:13:56 GMT (envelope-from gnats) Resent-Date: Sun, 4 Dec 2011 10:13:56 GMT Resent-Message-Id: <201112041013.pB4ADudb065181@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Peter Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 64FE0106566C for ; Sun, 4 Dec 2011 03:43:43 +0000 (UTC) (envelope-from pmc@citylink.dinoex.sub.de) Received: from uucp.dinoex.sub.de (uucp.dinoex.sub.de [194.45.71.2]) by mx1.freebsd.org (Postfix) with ESMTP id B4D208FC13 for ; Sun, 4 Dec 2011 03:43:42 +0000 (UTC) Received: from uucp.dinoex.sub.de (uucp@uucp.dinoex.sub.de [194.45.71.2] (may be forged)) by uucp.dinoex.sub.de (8.14.4/8.14.4) with ESMTP id pB43D4c4041385 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 4 Dec 2011 04:13:04 +0100 (CET) (envelope-from pmc@citylink.dinoex.sub.de) Received: from citylink.dinoex.sub.de (uucp@localhost) by uucp.dinoex.sub.de (8.14.4/8.14.4/Submit) with UUCP id pB43D4QK041384 for FreeBSD-gnats-submit@freebsd.org; Sun, 4 Dec 2011 04:13:04 +0100 (CET) (envelope-from pmc@citylink.dinoex.sub.de) Received: from gate.oper.dinoex.org (gate-e [192.168.98.2]) by citylink.dinoex.sub.de (8.14.5/8.14.5) with ESMTP id pB42E8d3031726 for ; Sun, 4 Dec 2011 03:14:08 +0100 (CET) (envelope-from pmc@disp.oper.dinoex.org) Received: from disp.oper.dinoex.org (disp-e.oper.dinoex.org [192.168.97.18]) by gate.oper.dinoex.org (8.14.5/8.14.5) with ESMTP id pB42DCa3031609 for ; Sun, 4 Dec 2011 03:13:12 +0100 (CET) (envelope-from pmc@disp.oper.dinoex.org) Received: from disp.oper.dinoex.org (localhost [127.0.0.1]) by disp.oper.dinoex.org (8.14.5/8.14.5) with ESMTP id pB42B8nY002215 for ; Sun, 4 Dec 2011 03:11:09 +0100 (CET) (envelope-from pmc@disp.oper.dinoex.org) Received: (from pmc@localhost) by disp.oper.dinoex.org (8.14.5/8.14.5/Submit) id pB42B8gd002214; Sun, 4 Dec 2011 03:11:08 +0100 (CET) (envelope-from pmc) Message-Id: <201112040211.pB42B8gd002214@disp.oper.dinoex.org> Date: Sun, 4 Dec 2011 03:11:08 +0100 (CET) From: Peter To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/163053: [fix] 'camcontrol nego -D' is ignored X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Peter List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Dec 2011 10:13:57 -0000 >Number: 163053 >Category: bin >Synopsis: [fix] 'camcontrol nego -D' is ignored >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Dec 04 10:13:56 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Peter Much >Release: FreeBSD 7.4-STABLE i386 >Organization: n/a >Environment: System: FreeBSD disp.oper.dinoex.org 7.4-STABLE FreeBSD 7.4-STABLE #14: Sat Dec 3 20:55:11 CET 2011 root@disp.oper.dinoex.org:/usr/src/sys/i386/compile/D1R74V1 i386 Seems to be present in Current, too. >Description: The "-D" option to "camcontrol nego" has no actual effect, except when applied together with some other option. This is obvious from the (missing) code. >How-To-Repeat: just try it out. >Fix: *** sbin/camcontrol/camcontrol.c.orig Sun Dec 4 03:06:01 2011 --- sbin/camcontrol/camcontrol.c Sun Dec 4 03:07:01 2011 *************** *** 2734,2739 **** --- 2734,2740 ---- spi->flags &= ~CTS_SPI_FLAGS_DISC_ENB; else spi->flags |= CTS_SPI_FLAGS_DISC_ENB; + didsettings++; } if (scsi && tag_enable != -1) { >Release-Note: >Audit-Trail: >Unformatted: