Date: Sat, 16 Feb 2002 16:49:45 -0800 (PST) From: Julian Elischer <julian@elischer.org> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: Alfred Perlstein <bright@mu.org>, Poul-Henning Kamp <phk@critter.freebsd.dk>, arch@FreeBSD.ORG, jhb@FreeBSD.ORG, peter@wemm.org, jake@locore.ca Subject: Re: gettimeofday() and crhold()/crfree() (was Re: gettimeofday() and copyout(). Is copyout() MPSAFE on non-i386 archs? ) Message-ID: <Pine.BSF.4.21.0202161647070.39539-200000@InterJet.elischer.org> In-Reply-To: <200202162200.g1GM04F39752@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text,
while the remaining parts are likely unreadable without MIME-aware tools.
Send mail to mime@docserver.cac.washington.edu for more info.
--0-1508433265-1013906985=:39539
Content-Type: TEXT/PLAIN; charset=US-ASCII
the whole point is moot..
you don't need to get or drop the creds at all..
see the attached patch I'm about to commit a version of..
On Sat, 16 Feb 2002, Matthew Dillon wrote:
>
> :Go ahead with using mutex pools for creds, I thought I'd done it
> :already but it looks like I only got to struct file and struct
> :uidinfo. :)
> :
> :I do sort of think that keeping your own cred freelist is probably
> :a bad idea especially with what Jeff R has coming down the pipe for
> :us. But we can take that out later if something better comes along.
> :
> :-Alfred
>
> Well, I dunno... I'm warming to the idea if it in fact eases the job
> of pushing Giant down. It seems so easy to do for the ucred, though
> of course I am not trying to proactively trim down the size of the
> freelist (yet)... but even that would be fairly simple to do in the
> allocation code by adding a count of the number of items in the freelist.
>
> It would be another ten lines of code relative to the patch
> I just posted. int cr_free_count; .. in allocation code do
> while (cr_free_count > HYSTERESIS) { ... free ... }
>
> -Matt
> Matthew Dillon
> <dillon@backplane.com>
>
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-arch" in the body of the message
>
--0-1508433265-1013906985=:39539
Content-Type: TEXT/PLAIN; charset=US-ASCII; name=thediff
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.BSF.4.21.0202161649450.39539@InterJet.elischer.org>
Content-Description:
Content-Disposition: attachment; filename=thediff
PyBpMzg2L2NvbmYvTElOVA0KPyBtb2R1bGVzL25ldGdyYXBoL2tzb2NrZXQv
bmdfa3NvY2tldC5rbGQNCj8gbW9kdWxlcy9uZXRncmFwaC9rc29ja2V0L25n
X2tzb2NrZXQua28NCkluZGV4OiBpMzg2L2kzODYvdHJhcC5jDQo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTogL2hvbWUvbmN2cy9zcmMvc3lz
L2kzODYvaTM4Ni90cmFwLmMsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjIx
MQ0KZGlmZiAtdSAtcjEuMjExIHRyYXAuYw0KLS0tIGkzODYvaTM4Ni90cmFw
LmMJMTAgSmFuIDIwMDIgMTE6NDk6NTQgLTAwMDAJMS4yMTENCisrKyBpMzg2
L2kzODYvdHJhcC5jCTEzIEZlYiAyMDAyIDAxOjA3OjA3IC0wMDAwDQpAQCAt
MjU2LDkgKzI1Niw4IEBADQogCQlzdGlja3MgPSB0ZC0+dGRfa3NlLT5rZV9z
dGlja3M7DQogCQl0ZC0+dGRfZnJhbWUgPSAmZnJhbWU7DQogCQlLQVNTRVJU
KHRkLT50ZF91Y3JlZCA9PSBOVUxMLCAoImFscmVhZHkgaGF2ZSBhIHVjcmVk
IikpOw0KLQkJUFJPQ19MT0NLKHApOw0KLQkJdGQtPnRkX3VjcmVkID0gY3Jo
b2xkKHAtPnBfdWNyZWQpOw0KLQkJUFJPQ19VTkxPQ0socCk7DQorCQlpZiAo
dGQtPnRkX3VjcmVkICE9IHAtPnBfdWNyZWQpIA0KKwkJCWFxdWlyZV91Y3Jl
ZCh0ZCwgcCk7DQogDQogCQlzd2l0Y2ggKHR5cGUpIHsNCiAJCWNhc2UgVF9Q
UklWSU5GTFQ6CS8qIHByaXZpbGVnZWQgaW5zdHJ1Y3Rpb24gZmF1bHQgKi8N
CkBAIC02NDQsMTAgKzY0MywxMiBAQA0KIAl1c2VycmV0KHRkLCAmZnJhbWUs
IHN0aWNrcyk7DQogCW10eF9hc3NlcnQoJkdpYW50LCBNQV9OT1RPV05FRCk7
DQogdXNlcm91dDoNCisjaWZkZWYJSU5WQVJJQU5UUw0KIAltdHhfbG9jaygm
R2lhbnQpOw0KIAljcmZyZWUodGQtPnRkX3VjcmVkKTsNCiAJbXR4X3VubG9j
aygmR2lhbnQpOw0KIAl0ZC0+dGRfdWNyZWQgPSBOVUxMOw0KKyNlbmRpZg0K
IG91dDoNCiAJcmV0dXJuOw0KIH0NCkBAIC05NTQsOSArOTU1LDggQEANCiAJ
c3RpY2tzID0gdGQtPnRkX2tzZS0+a2Vfc3RpY2tzOw0KIAl0ZC0+dGRfZnJh
bWUgPSAmZnJhbWU7DQogCUtBU1NFUlQodGQtPnRkX3VjcmVkID09IE5VTEws
ICgiYWxyZWFkeSBoYXZlIGEgdWNyZWQiKSk7DQotCVBST0NfTE9DSyhwKTsN
Ci0JdGQtPnRkX3VjcmVkID0gY3Job2xkKHAtPnBfdWNyZWQpOw0KLQlQUk9D
X1VOTE9DSyhwKTsNCisJaWYgKHRkLT50ZF91Y3JlZCAhPSBwLT5wX3VjcmVk
KSANCisJCWFxdWlyZV91Y3JlZCh0ZCwgcCk7DQogCXBhcmFtcyA9IChjYWRk
cl90KWZyYW1lLnRmX2VzcCArIHNpemVvZihpbnQpOw0KIAljb2RlID0gZnJh
bWUudGZfZWF4Ow0KIAlvcmlnX3RmX2VmbGFncyA9IGZyYW1lLnRmX2VmbGFn
czsNCkBAIC0xMDk5LDEwICsxMDk5LDEyIEBADQogCSAqLw0KIAlTVE9QRVZF
TlQocCwgU19TQ1gsIGNvZGUpOw0KIA0KKyNpZmRlZglJTlZBUklBTlRTDQog
CW10eF9sb2NrKCZHaWFudCk7DQogCWNyZnJlZSh0ZC0+dGRfdWNyZWQpOw0K
IAltdHhfdW5sb2NrKCZHaWFudCk7DQogCXRkLT50ZF91Y3JlZCA9IE5VTEw7
DQorI2VuZGlmDQogI2lmZGVmIFdJVE5FU1MNCiAJaWYgKHdpdG5lc3NfbGlz
dCh0ZCkpIHsNCiAJCXBhbmljKCJzeXN0ZW0gY2FsbCAlcyByZXR1cm5pbmcg
d2l0aCBtdXRleChzKSBoZWxkXG4iLA0KSW5kZXg6IGtlcm4va2Vybl9mb3Jr
LmMNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvaG9tZS9u
Y3ZzL3NyYy9zeXMva2Vybi9rZXJuX2ZvcmsuYyx2DQpyZXRyaWV2aW5nIHJl
dmlzaW9uIDEuMTMwDQpkaWZmIC11IC1yMS4xMzAga2Vybl9mb3JrLmMNCi0t
LSBrZXJuL2tlcm5fZm9yay5jCTcgRmViIDIwMDIgMjM6MDY6MjYgLTAwMDAJ
MS4xMzANCisrKyBrZXJuL2tlcm5fZm9yay5jCTEzIEZlYiAyMDAyIDAxOjA3
OjExIC0wMDAwDQpAQCAtNzk5LDEwICs3OTksMTIgQEANCiAJCWt0aHJlYWRf
ZXhpdCgwKTsNCiAJfQ0KIAlQUk9DX1VOTE9DSyhwKTsNCisjaWZkZWYJSU5W
QVJJQU5UUw0KIAltdHhfbG9jaygmR2lhbnQpOw0KIAljcmZyZWUodGQtPnRk
X3VjcmVkKTsNCiAJbXR4X3VubG9jaygmR2lhbnQpOw0KIAl0ZC0+dGRfdWNy
ZWQgPSBOVUxMOw0KKyNlbmRpZg0KIAltdHhfYXNzZXJ0KCZHaWFudCwgTUFf
Tk9UT1dORUQpOw0KIH0NCiANCkluZGV4OiBrZXJuL3N1YnJfdHJhcC5jDQo9
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmlsZTogL2hvbWUvbmN2cy9z
cmMvc3lzL2tlcm4vc3Vicl90cmFwLmMsdg0KcmV0cmlldmluZyByZXZpc2lv
biAxLjIwNw0KZGlmZiAtdSAtcjEuMjA3IHN1YnJfdHJhcC5jDQotLS0ga2Vy
bi9zdWJyX3RyYXAuYwkxMSBGZWIgMjAwMiAyMDozNzo1MyAtMDAwMAkxLjIw
Nw0KKysrIGtlcm4vc3Vicl90cmFwLmMJMTMgRmViIDIwMDIgMDE6MDc6MTIg
LTAwMDANCkBAIC01Niw2ICs1NiwyNCBAQA0KICNpbmNsdWRlIDxtYWNoaW5l
L3BjYi5oPg0KIA0KIC8qDQorICogc21hbGwgcm91dGluZSB0byBzd2FwIGEg
dGhyZWFkJ3MgY3VycmVudCB1Y3JlZCBmb3IgdGhlIGNvcnJlY3Qgb25lDQor
ICogdGFrZW4gZnJvbSB0aGUgcHJvY2Vzcw0KKyAqLw0KK3ZvaWQNCithcXVp
cmVfdWNyZWQoc3RydWN0IHRocmVhZCAqdGQsIHN0cnVjdCBwcm9jICpwKQ0K
K3sNCisJaWYgKHRkLT50ZF91Y3JlZCAhPSBOVUxMKSB7DQorCQltdHhfbG9j
aygmR2lhbnQpOw0KKwkJY3JmcmVlKHRkLT50ZF91Y3JlZCk7DQorCQltdHhf
dW5sb2NrKCZHaWFudCk7DQorCQl0ZC0+dGRfdWNyZWQgPSBOVUxMOw0KKwl9
DQorCVBST0NfTE9DSyhwKTsNCisJdGQtPnRkX3VjcmVkID0gY3Job2xkKHAt
PnBfdWNyZWQpOw0KKwlQUk9DX1VOTE9DSyhwKTsNCit9DQorDQorLyoNCiAg
KiBEZWZpbmUgdGhlIGNvZGUgbmVlZGVkIGJlZm9yZSByZXR1cm5pbmcgdG8g
dXNlciBtb2RlLCBmb3INCiAgKiB0cmFwIGFuZCBzeXNjYWxsLg0KICAqDQpA
QCAtMTYxLDkgKzE3OSw4IEBADQogCQkJcC0+cF9zdGF0cy0+cF9wcm9mLnBy
X3RpY2tzID0gMDsNCiAJCX0NCiAJCW10eF91bmxvY2tfc3Bpbigmc2NoZWRf
bG9jayk7DQotCQlQUk9DX0xPQ0socCk7DQotCQl0ZC0+dGRfdWNyZWQgPSBj
cmhvbGQocC0+cF91Y3JlZCk7DQotCQlQUk9DX1VOTE9DSyhwKTsNCisJCWlm
ICh0ZC0+dGRfdWNyZWQgIT0gcC0+cF91Y3JlZCkgDQorCQkJYXF1aXJlX3Vj
cmVkKHRkLCBwKTsNCiAJCWlmIChmbGFncyAmIEtFRl9PV0VVUEMgJiYgc2Zs
YWcgJiBQU19QUk9GSUwpDQogCQkJYWRkdXBjX3Rhc2soa2UsIHAtPnBfc3Rh
dHMtPnBfcHJvZi5wcl9hZGRyLCBwcnRpY2tzKTsNCiAJCWlmIChzZmxhZyAm
IFBTX0FMUk1QRU5EKSB7DQpAQCAtMTg4LDEwICsyMDUsMTIgQEANCiAJCX0N
CiANCiAJCXVzZXJyZXQodGQsIGZyYW1lcCwgc3RpY2tzKTsNCisjaWZkZWYJ
SU5WQVJJQU5UUw0KIAkJbXR4X2xvY2soJkdpYW50KTsNCiAJCWNyZnJlZSh0
ZC0+dGRfdWNyZWQpOw0KIAkJbXR4X3VubG9jaygmR2lhbnQpOw0KIAkJdGQt
PnRkX3VjcmVkID0gTlVMTDsNCisjZW5kaWYNCiAJCXMgPSBjcHVfY3JpdGlj
YWxfZW50ZXIoKTsNCiAJfQ0KIAltdHhfYXNzZXJ0KCZHaWFudCwgTUFfTk9U
T1dORUQpOw0KSW5kZXg6IHN5cy91Y3JlZC5oDQo9PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09DQpSQ1MgZmlsZTogL2hvbWUvbmN2cy9zcmMvc3lzL3N5cy91Y3Jl
ZC5oLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4yNg0KZGlmZiAtdSAtcjEu
MjYgdWNyZWQuaA0KLS0tIHN5cy91Y3JlZC5oCTExIE9jdCAyMDAxIDIzOjM4
OjE3IC0wMDAwCTEuMjYNCisrKyBzeXMvdWNyZWQuaAkxMyBGZWIgMjAwMiAw
MTowNzoyMiAtMDAwMA0KQEAgLTgzLDE5ICs4MywyMCBAQA0KICNpZmRlZiBf
S0VSTkVMDQogDQogDQotdm9pZAkJY2hhbmdlX2VnaWQgX19QKChzdHJ1Y3Qg
dWNyZWQgKm5ld2NyZWQsIGdpZF90IGVnaWQpKTsNCi12b2lkCQljaGFuZ2Vf
ZXVpZCBfX1AoKHN0cnVjdCB1Y3JlZCAqbmV3Y3JlZCwgdWlkX3QgZXVpZCkp
Ow0KLXZvaWQJCWNoYW5nZV9yZ2lkIF9fUCgoc3RydWN0IHVjcmVkICpuZXdj
cmVkLCBnaWRfdCByZ2lkKSk7DQotdm9pZAkJY2hhbmdlX3J1aWQgX19QKChz
dHJ1Y3QgdWNyZWQgKm5ld2NyZWQsIHVpZF90IHJ1aWQpKTsNCi12b2lkCQlj
aGFuZ2Vfc3ZnaWQgX19QKChzdHJ1Y3QgdWNyZWQgKm5ld2NyZWQsIGdpZF90
IHN2Z2lkKSk7DQotdm9pZAkJY2hhbmdlX3N2dWlkIF9fUCgoc3RydWN0IHVj
cmVkICpuZXdjcmVkLCB1aWRfdCBzdnVpZCkpOw0KLXZvaWQJCWNyY29weSBf
X1AoKHN0cnVjdCB1Y3JlZCAqZGVzdCwgc3RydWN0IHVjcmVkICpzcmMpKTsN
Ci1zdHJ1Y3QgdWNyZWQJKmNyZHVwIF9fUCgoc3RydWN0IHVjcmVkICpjcikp
Ow0KLXZvaWQJCWNyZnJlZSBfX1AoKHN0cnVjdCB1Y3JlZCAqY3IpKTsNCi1z
dHJ1Y3QgdWNyZWQJKmNyZ2V0IF9fUCgodm9pZCkpOw0KLXN0cnVjdCB1Y3Jl
ZAkqY3Job2xkIF9fUCgoc3RydWN0IHVjcmVkICpjcikpOw0KLWludAkJY3Jz
aGFyZWQgX19QKChzdHJ1Y3QgdWNyZWQgKmNyKSk7DQotaW50CQlncm91cG1l
bWJlciBfX1AoKGdpZF90IGdpZCwgc3RydWN0IHVjcmVkICpjcmVkKSk7DQor
dm9pZAkJYXF1aXJlX3VjcmVkKHN0cnVjdCB0aHJlYWQgKnRkLCBzdHJ1Y3Qg
cHJvYyAqcCk7DQordm9pZAkJY2hhbmdlX2VnaWQgKHN0cnVjdCB1Y3JlZCAq
bmV3Y3JlZCwgZ2lkX3QgZWdpZCk7DQordm9pZAkJY2hhbmdlX2V1aWQgKHN0
cnVjdCB1Y3JlZCAqbmV3Y3JlZCwgdWlkX3QgZXVpZCk7DQordm9pZAkJY2hh
bmdlX3JnaWQgKHN0cnVjdCB1Y3JlZCAqbmV3Y3JlZCwgZ2lkX3QgcmdpZCk7
DQordm9pZAkJY2hhbmdlX3J1aWQgKHN0cnVjdCB1Y3JlZCAqbmV3Y3JlZCwg
dWlkX3QgcnVpZCk7DQordm9pZAkJY2hhbmdlX3N2Z2lkIChzdHJ1Y3QgdWNy
ZWQgKm5ld2NyZWQsIGdpZF90IHN2Z2lkKTsNCit2b2lkCQljaGFuZ2Vfc3Z1
aWQgKHN0cnVjdCB1Y3JlZCAqbmV3Y3JlZCwgdWlkX3Qgc3Z1aWQpOw0KK3Zv
aWQJCWNyY29weSAoc3RydWN0IHVjcmVkICpkZXN0LCBzdHJ1Y3QgdWNyZWQg
KnNyYyk7DQorc3RydWN0IHVjcmVkCSpjcmR1cCAoc3RydWN0IHVjcmVkICpj
cik7DQordm9pZAkJY3JmcmVlIChzdHJ1Y3QgdWNyZWQgKmNyKTsNCitzdHJ1
Y3QgdWNyZWQJKmNyZ2V0ICh2b2lkKTsNCitzdHJ1Y3QgdWNyZWQJKmNyaG9s
ZCAoc3RydWN0IHVjcmVkICpjcik7DQoraW50CQljcnNoYXJlZCAoc3RydWN0
IHVjcmVkICpjcik7DQoraW50CQlncm91cG1lbWJlciAoZ2lkX3QgZ2lkLCBz
dHJ1Y3QgdWNyZWQgKmNyZWQpOw0KICNlbmRpZiAvKiBfS0VSTkVMICovDQog
DQogI2VuZGlmIC8qICFfU1lTX1VDUkVEX0hfICovDQo=
--0-1508433265-1013906985=:39539--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0202161647070.39539-200000>