From owner-freebsd-current@FreeBSD.ORG  Fri Jul 13 08:54:16 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id DD6DB16A403
	for <freebsd-current@freebsd.org>; Fri, 13 Jul 2007 08:54:16 +0000 (UTC)
	(envelope-from thompsa@FreeBSD.org)
Received: from heff.fud.org.nz (203-109-251-39.static.bliink.ihug.co.nz
	[203.109.251.39])
	by mx1.freebsd.org (Postfix) with ESMTP id 8447E13C491
	for <freebsd-current@freebsd.org>; Fri, 13 Jul 2007 08:54:16 +0000 (UTC)
	(envelope-from thompsa@FreeBSD.org)
Received: by heff.fud.org.nz (Postfix, from userid 1001)
	id CFF0D1CC5D; Fri, 13 Jul 2007 20:54:14 +1200 (NZST)
Date: Fri, 13 Jul 2007 20:54:14 +1200
From: Andrew Thompson <thompsa@FreeBSD.org>
To: d@delphij.net
Message-ID: <20070713085414.GC11395@heff.fud.org.nz>
References: <46970DF7.3000803@elischer.org> <46972B28.1010409@FreeBSD.org>
	<200707131021.59966.hselasky@c2i.net>
	<46973A08.3030607@delphij.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <46973A08.3030607@delphij.net>
User-Agent: Mutt/1.5.13 (2006-08-11)
Cc: attilio@freebsd.org, freebsd-current@freebsd.org,
	Julian Elischer <julian@elischer.org>,
	Hans Petter Selasky <hselasky@c2i.net>
Subject: Re: crash in tty code in 6.1.. fixed since?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Jul 2007 08:54:16 -0000

On Fri, Jul 13, 2007 at 04:38:32PM +0800, LI Xin wrote:
> Hans Petter Selasky wrote:
> [...]
> > Maybe related:
> > 
> > Regarding the keyboard system which is also Giant locked, we should add assert 
> > Giant statements, because I see several callers doing calls into the keyboard 
> > system without holding Giant!
> 
> I think that is a good idea.  By adding these assertions our user
> community would be able to catch more under-exercised codepath under
> their workload.

Well hopefully the developer adding the assertions would attempt to find
them all first rather than 'fishing' for a panic. :)