From owner-dev-commits-src-all@freebsd.org  Thu Jan  7 13:34:43 2021
Return-Path: <owner-dev-commits-src-all@freebsd.org>
Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id AB4CB4D0CDF;
 Thu,  7 Jan 2021 13:34:43 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4DBRzl4HCTz53qK;
 Thu,  7 Jan 2021 13:34:43 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com
 [209.85.219.51])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK))
 (Authenticated sender: kevans)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 8157625B08;
 Thu,  7 Jan 2021 13:34:43 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: by mail-qv1-f51.google.com with SMTP id s6so2724211qvn.6;
 Thu, 07 Jan 2021 05:34:43 -0800 (PST)
X-Gm-Message-State: AOAM530XXZUiSU2YfIkb6M6JCPUzQ22NwuIEFusuRcYMio8TXlffhVIM
 wbfaWVkpMUm82PrzcvKNqt81PAMc1BKUzpwaLMo=
X-Google-Smtp-Source: ABdhPJyF8lbjE9Qtxgle2DVrfq1rHbW2i+BjEg3UiTHG5HH2LQtXALqvnNncdq/P5+tbHxMyWUt60azHzFogE6AFHLI=
X-Received: by 2002:a05:6214:6af:: with SMTP id
 s15mr8435562qvz.34.1610026483182; 
 Thu, 07 Jan 2021 05:34:43 -0800 (PST)
MIME-Version: 1.0
References: <202012311717.0BVHHp4G092948@gitrepo.freebsd.org>
 <X/a9GyfJzAhr1M8I@server.rulingia.com>
In-Reply-To: <X/a9GyfJzAhr1M8I@server.rulingia.com>
From: Kyle Evans <kevans@freebsd.org>
Date: Thu, 7 Jan 2021 07:34:30 -0600
X-Gmail-Original-Message-ID: <CACNAnaGcqO7TYHFxn0H1=QHKDRNBqdH6S7+G2S_migxyY_+rmQ@mail.gmail.com>
Message-ID: <CACNAnaGcqO7TYHFxn0H1=QHKDRNBqdH6S7+G2S_migxyY_+rmQ@mail.gmail.com>
Subject: Re: git: ac5f382a9d0a - main - stand: properly declare subdir deps or
 .WAIT, do parallel build
To: Peter Jeremy <peter@rulingia.com>
Cc: src-committers <src-committers@freebsd.org>,
 dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: dev-commits-src-all@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for all branches of the src repository
 <dev-commits-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-all/>
List-Post: <mailto:dev-commits-src-all@freebsd.org>
List-Help: <mailto:dev-commits-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Jan 2021 13:34:43 -0000

On Thu, Jan 7, 2021 at 1:50 AM Peter Jeremy <peter@rulingia.com> wrote:
>
> On 2020-Dec-31 17:17:51 +0000, Kyle Evans <kevans@FreeBSD.org> wrote:
> >The branch main has been updated by kevans:
> >
> >URL: https://cgit.FreeBSD.org/src/commit/?id=ac5f382a9d0a26685b92b49abb845d3b30ea5f91
> >
> >commit ac5f382a9d0a26685b92b49abb845d3b30ea5f91
> >Author:     Kyle Evans <kevans@FreeBSD.org>
> >AuthorDate: 2020-12-31 17:15:45 +0000
> >Commit:     Kyle Evans <kevans@FreeBSD.org>
> >CommitDate: 2020-12-31 17:15:45 +0000
>
> This commit adds fdt as a hard dependency for efi but leaves fdt as
> optionally built based on WITH_FDT.  As a result, adding WITHOUT_FDT=yes
> causes the build to fail:
> make[3]: don't know how to make all_subdir_stand/fdt. Stop
>
> Either MK_FDT needs to be forced on by MK_EFI or the dependency needs to
> be made conditional.
>

Ah, yes, sorry- will fix. It looks like that should be the only other
conditional dep that I missed here. The latter option is what we opt
for here-

Thanks,

Kyle Evans