From owner-svn-src-head@freebsd.org Wed Aug 22 00:17:18 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E99BD10843D2; Wed, 22 Aug 2018 00:17:17 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 86FAF761FA; Wed, 22 Aug 2018 00:17:17 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from mail-it0-f46.google.com (mail-it0-f46.google.com [209.85.214.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) (Authenticated sender: mmacy) by smtp.freebsd.org (Postfix) with ESMTPSA id 43EDEF78B; Wed, 22 Aug 2018 00:17:17 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: by mail-it0-f46.google.com with SMTP id e14-v6so800976itf.1; Tue, 21 Aug 2018 17:17:17 -0700 (PDT) X-Gm-Message-State: APzg51BZVlJYbfpXouz08+TEv/SRgtH99hSSqh9So6GtRi6LP7l7g1dY AusRYA5gjzVSPqB0TDIyt0D/XsMA/yd2Mhs92gU= X-Google-Smtp-Source: ANB0Vdb9A7gtRUR5GXgTUMp0xKAuu5tQMtQV5hElI76Wcy8+c2Ipd/OLq+6T3JaU+c67oADlxklzLzFDx1WAj90TwVw= X-Received: by 2002:a24:670a:: with SMTP id u10-v6mr1328265itc.31.1534897036552; Tue, 21 Aug 2018 17:17:16 -0700 (PDT) MIME-Version: 1.0 References: <201808152023.w7FKN9LL055254@repo.freebsd.org> <20180821212047.GM27633@FreeBSD.org> <20180821235227.GB55580@raichu> In-Reply-To: <20180821235227.GB55580@raichu> From: Matthew Macy Date: Tue, 21 Aug 2018 17:17:05 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r337866 - in head/sys: net netinet netinet6 To: Mark Johnston Cc: Gleb Smirnoff , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2018 00:17:18 -0000 On Tue, Aug 21, 2018 at 16:52 Mark Johnston wrote: > On Tue, Aug 21, 2018 at 04:00:10PM -0700, Matthew Macy wrote: > > Yes. See r338162. Thanks. > > You missed instances of the same bug in in_mcast.c and in6_mcast.c. Thanks > > > > On Tue, Aug 21, 2018 at 2:24 PM Gleb Smirnoff > wrote: > > > On Wed, Aug 15, 2018 at 08:23:09PM +0000, Matt Macy wrote: > > > M> @@ -3772,8 +3775,11 @@ if_delmulti_locked(struct ifnet *ifp, struct > > > ifmultiad > > > M> ll_ifma->ifma_ifp = NULL; /* XXX */ > > > M> if (--ll_ifma->ifma_refcount == 0) { > > > M> if (ifp != NULL) { > > > M> - CK_STAILQ_REMOVE(&ifp->if_multiaddrs, > > > ll_ifma, ifmultiaddr, > > > M> - ifma_link); > > > M> + if (ll_ifma->ifma_flags & > IFMA_F_ENQUEUED) > > > { > > > M> + > > > CK_STAILQ_REMOVE(&ifp->if_multiaddrs, ll_ifma, ifmultiaddr, > > > M> + ifma_link); > > > M> + ifma->ifma_flags &= > > > ~IFMA_F_ENQUEUED; > > > M> + } > > > M> } > > > M> if_freemulti(ll_ifma); > > > M> } > > > > > > Coverity suggested there is a cut and paste mistake here, and it is > > > compilable. > > > After quick glance I tend to agree. Looks like flag is cleared on wrong > > > ifma. > > > > > > -- > > > Gleb Smirnoff > > > >