From owner-cvs-all Sun Oct 8 4:12:27 2000 Delivered-To: cvs-all@freebsd.org Received: from lucifer.ninth-circle.org (lucifer.bart.nl [194.158.168.74]) by hub.freebsd.org (Postfix) with ESMTP id A68AB37B66D; Sun, 8 Oct 2000 04:12:20 -0700 (PDT) Received: (from asmodai@localhost) by lucifer.ninth-circle.org (8.11.0/8.11.0) id e98BCFH70180; Sun, 8 Oct 2000 13:12:15 +0200 (CEST) (envelope-from asmodai) Date: Sun, 8 Oct 2000 13:12:15 +0200 From: Jeroen Ruigrok van der Werven To: David Malone Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys mbuf.h Message-ID: <20001008131215.A69484@lucifer.bart.nl> References: <200010080952.CAA54550@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200010080952.CAA54550@freefall.freebsd.org>; from dwmalone@FreeBSD.org on Sun, Oct 08, 2000 at 02:52:50AM -0700 Organisation: VIA Net.Works The Netherlands Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG -On [20001008 11:55], David Malone (dwmalone@FreeBSD.org) wrote: > Log: > KASSERT that mbuf external reference counts are > 0 before we remove > a reference. (Agreed to by Bosko some time ago). Thanks, we need more strategically placed assert(), KASSERT(), SPLASSERT(), CONDSPLASSERT() en the new SPLASSERT() successor(if there is one) in the sources. We cannot permit to have new commits blow up old existing code. We also need more regression tests and data structure integrity checks in order to maintain backwards compatibility. I have this stuff on my plate, but I am loaded with things at work, as well as at home. All the help is appreciated, feel free to submit PR's and/or patches and point them out to me. Although I am pressed for time, I will make an effort to look them over, if needed get more judgement on them, and then put them in the source tree. It is now time we start focussing on source tree maintenance aside from featurism, and hey, since I am not a real kernel hacker, I am suited for this sort of thing, I hope. :) -- Jeroen Ruigrok van der Werven Network- and systemadministrator VIA Net.Works The Netherlands BSD: Technical excellence at its best http://www.via-net-works.nl Grant me the serenity to accept the things I cannot change, courage to change the things I can, and wisdom to know the difference... To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message