From owner-cvs-src@FreeBSD.ORG Mon May 21 04:33:23 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9D86A16A400; Mon, 21 May 2007 04:33:23 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 51ADA13C46E; Mon, 21 May 2007 04:33:23 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id l4L4XK62084088; Sun, 20 May 2007 22:33:20 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <4651210F.3000706@samsco.org> Date: Sun, 20 May 2007 22:33:19 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1 MIME-Version: 1.0 To: mjacob@FreeBSD.org References: <200705201649.l4KGnApl032671@repoman.freebsd.org> <20070521132204.D86236@besplex.bde.org> <20070520212020.D71516@ns1.feral.com> In-Reply-To: <20070520212020.D71516@ns1.feral.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Sun, 20 May 2007 22:33:20 -0600 (MDT) X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Bruce Evans Subject: Re: cvs commit: src/sys/dev/hptmv ioctl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2007 04:33:23 -0000 mjacob@FreeBSD.org wrote: >>> mjacob 2007-05-20 16:49:10 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/dev/hptmv ioctl.c >>> Log: >>> Make gcc 4.2 happy by initiatlizing controller && channel prior >>> to a call to a function which *might* then initialize them. >>> >>> MFC after: 3 days >> >> Isn't the bug that the function doesn't always initialize them? >> >> Bruce >> > > That was a meta-comment- I should have made it clearer. The function > get_disk_location *will* always init them, but gcc-4.2 doesn't know > that, and unlike previous versions of gcc, gcc-4.2 no longer will assume > that a function that you pass a pointer to local data to will actually > fill them in. > > -matt > Sounds like more wonderful roadblocks from the GCC team. GCC is a great app, but it would be nice if it could be used as a tool for software development. Scott