From owner-freebsd-cvsweb@FreeBSD.ORG Wed Feb 27 18:27:37 2008 Return-Path: Delivered-To: cvsweb@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4ED811065675 for ; Wed, 27 Feb 2008 18:27:37 +0000 (UTC) (envelope-from mwlucas@bewilderbeast.blackhelicopters.org) Received: from bewilderbeast.blackhelicopters.org (bewilderbeast.blackhelicopters.org [198.22.63.8]) by mx1.freebsd.org (Postfix) with ESMTP id E271C8FC18 for ; Wed, 27 Feb 2008 18:27:36 +0000 (UTC) (envelope-from mwlucas@bewilderbeast.blackhelicopters.org) Received: from bewilderbeast.blackhelicopters.org (localhost [127.0.0.1]) by bewilderbeast.blackhelicopters.org (8.14.1/8.13.8) with ESMTP id m1RIRZ70011478; Wed, 27 Feb 2008 13:27:35 -0500 (EST) (envelope-from mwlucas@bewilderbeast.blackhelicopters.org) Received: (from mwlucas@localhost) by bewilderbeast.blackhelicopters.org (8.14.1/8.13.8/Submit) id m1RIRZG9011477; Wed, 27 Feb 2008 13:27:35 -0500 (EST) (envelope-from mwlucas) Date: Wed, 27 Feb 2008 13:27:35 -0500 From: "Michael W. Lucas" To: Mark Koopman Message-ID: <20080227182735.GA11421@bewilderbeast.blackhelicopters.org> References: <20080227121008.GA9816@bewilderbeast.blackhelicopters.org> <9B4F3DF197EBF24C8496ADAE488DAEFE1F0B10@exchange05.orm.omniture.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9B4F3DF197EBF24C8496ADAE488DAEFE1F0B10@exchange05.orm.omniture.com> User-Agent: Mutt/1.4.2.2i X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (bewilderbeast.blackhelicopters.org [127.0.0.1]); Wed, 27 Feb 2008 13:27:35 -0500 (EST) Cc: cvsweb@freebsd.org Subject: Re: problem with colored diffs X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2008 18:27:37 -0000 On Wed, Feb 27, 2008 at 08:16:01AM -0800, Mark Koopman wrote: > We had a similar problem with diffs in general, and > I had to add a call to umask to fix the problem. > > ## line 2338 cvsweb > if (!open($fh, "-|")) { # child > open(STDERR, ">&STDOUT"); # Redirect stderr to stdout > openOutputFilter(); > # adding umask to fix CVSWEB diff > umask 0022; > exec($CMD{rcsdiff}, @rcsdiff_options, @difftype, "-r$rev1", "-r$rev2", > $fullname) or exit -1; > } > > diff cvsweb.cgi.orig cvsweb.cgi > 2337a2338 > > # adding umask to fix CVSWEB diff > > umask 0022; Thanks for the suggestion. I tried it. No success, but I did get different behavior. Rather than failing silently, firefox tells me that it's trying to open the file "hostname.diff", and would I like to save or open it? It's a 0-size file. Thanks, ==ml > > > -----Original Message----- > From: owner-freebsd-cvsweb@freebsd.org on behalf of Michael W. Lucas > Sent: Wed 2/27/2008 4:10 AM > To: cvsweb@freebsd.org > Subject: problem with colored diffs > > Hi, > > I'm using cvsweb-3.0.6_1 on FreeBSD/amd64 7.0-beta2. > > Everything except the colored diffs works flawlessly. > > When I try to get a colored diff, however, the page comes up blank. > No error message is logged in the Apache logs or in /var/log/messages; > it appears to fail silently. > > Any suggestions on how I can capture an error message, or otherwise > debug this further? > > Thanks, > ==ml > > -- > Michael W. Lucas mwlucas@BlackHelicopters.org, mwlucas@FreeBSD.org > http://www.BlackHelicopters.org/~mwlucas/ > Now Shipping: "Absolute FreeBSD" -- http://www.AbsoluteFreeBSD.com > On 5/4/2007, the TSA kept 3 pairs of my soiled undies "for security reasons." > _______________________________________________ > freebsd-cvsweb@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-cvsweb > To unsubscribe, send any mail to "freebsd-cvsweb-unsubscribe@freebsd.org" > > -- Michael W. Lucas mwlucas@BlackHelicopters.org, mwlucas@FreeBSD.org http://www.BlackHelicopters.org/~mwlucas/ Now Shipping: "Absolute FreeBSD" -- http://www.AbsoluteFreeBSD.com On 5/4/2007, the TSA kept 3 pairs of my soiled undies "for security reasons."