Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 6 Apr 2015 23:31:49 -0700 (PDT)
From:      Don Lewis <truckman@FreeBSD.org>
To:        danfe@FreeBSD.org
Cc:        sunpoet@FreeBSD.org, svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: svn commit: r383472 - head/audio/muse
Message-ID:  <201504070631.t376VnAp041310@gw.catspoiler.org>
In-Reply-To: <20150407012902.GA22994@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On  7 Apr, Alexey Dokuchaev wrote:
> On Mon, Apr 06, 2015 at 06:59:20PM +0000, Sunpoet Po-Chuan Hsieh wrote:
>> New Revision: 383472
>> URL: https://svnweb.freebsd.org/changeset/ports/383472
>> 
>> [...]
>> @@ -52,6 +49,6 @@ post-patch:
>>  
>>  post-install:
>>  	@${MKDIR} ${STAGEDIR}${DOCSDIR}
>> -	${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}
>> +	(cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${STAGEDIR}${DOCSDIR})
> 
> Please do not change working and readable code into equivalent less-readable
> one.

I'm not particularly fond of either the original or the update, but the
original is obscure enough that I'd have to dig out the manual to figure
out what it even does.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201504070631.t376VnAp041310>