From owner-svn-src-head@freebsd.org Fri Feb 5 20:26:39 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BF672A77C62; Fri, 5 Feb 2016 20:26:39 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (glebi.us [96.95.210.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id A9DCA11FF; Fri, 5 Feb 2016 20:26:39 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id u15KQcNY077860 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 5 Feb 2016 12:26:39 -0800 (PST) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id u15KQc0R077859; Fri, 5 Feb 2016 12:26:38 -0800 (PST) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@FreeBSD.org using -f Date: Fri, 5 Feb 2016 12:26:38 -0800 From: Gleb Smirnoff To: Mark Johnston Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r295330 - head/sys/vm Message-ID: <20160205202638.GM72286@FreeBSD.org> References: <201602051935.u15JZr85032701@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201602051935.u15JZr85032701@repo.freebsd.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Feb 2016 20:26:39 -0000 Mark, thanks! Me culpa :( On Fri, Feb 05, 2016 at 07:35:53PM +0000, Mark Johnston wrote: M> Author: markj M> Date: Fri Feb 5 19:35:53 2016 M> New Revision: 295330 M> URL: https://svnweb.freebsd.org/changeset/base/295330 M> M> Log: M> Plug a vm_page leak introduced in r292373. M> M> Reported by: vangyzen M> M> Modified: M> head/sys/vm/sg_pager.c M> M> Modified: head/sys/vm/sg_pager.c M> ============================================================================== M> --- head/sys/vm/sg_pager.c Fri Feb 5 18:17:37 2016 (r295329) M> +++ head/sys/vm/sg_pager.c Fri Feb 5 19:35:53 2016 (r295330) M> @@ -189,6 +189,9 @@ sg_pager_getpages(vm_object_t object, vm M> VM_OBJECT_WLOCK(object); M> TAILQ_INSERT_TAIL(&object->un_pager.sgp.sgp_pglist, page, plinks.q); M> vm_page_replace_checked(page, object, offset, m[0]); M> + vm_page_lock(m[0]); M> + vm_page_free(m[0]); M> + vm_page_unlock(m[0]); M> m[0] = page; M> page->valid = VM_PAGE_BITS_ALL; M> M> _______________________________________________ M> svn-src-all@freebsd.org mailing list M> https://lists.freebsd.org/mailman/listinfo/svn-src-all M> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" -- Totus tuus, Glebius.