From owner-svn-src-projects@FreeBSD.ORG  Mon Oct  6 16:38:10 2014
Return-Path: <owner-svn-src-projects@FreeBSD.ORG>
Delivered-To: svn-src-projects@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 6F9405AB;
 Mon,  6 Oct 2014 16:38:10 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 48D7F6CF;
 Mon,  6 Oct 2014 16:38:10 +0000 (UTC)
Received: from ralph.baldwin.cx (pool-173-70-85-31.nwrknj.fios.verizon.net
 [173.70.85.31])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 3F172B977;
 Mon,  6 Oct 2014 12:38:09 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: "Alexander V. Chernikov" <melifaro@freebsd.org>
Subject: Re: svn commit: r272515 - projects/ipfw/sys/netpfil/ipfw
Date: Mon, 06 Oct 2014 11:45:26 -0400
Message-ID: <5520708.eFNh9vYom7@ralph.baldwin.cx>
User-Agent: KMail/4.12.5 (FreeBSD/10.1-BETA2; KDE/4.12.5; amd64; ; )
In-Reply-To: <201410041210.s94CAX7I012628@svn.freebsd.org>
References: <201410041210.s94CAX7I012628@svn.freebsd.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Mon, 06 Oct 2014 12:38:09 -0400 (EDT)
Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
 tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects/>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Oct 2014 16:38:10 -0000

On Saturday, October 04, 2014 12:10:33 PM Alexander V. Chernikov wrote:
> Author: melifaro
> Date: Sat Oct  4 12:10:32 2014
> New Revision: 272515
> URL: https://svnweb.freebsd.org/changeset/base/272515
> 
> Log:
>   Add "ipfw_ctl3" FEATURE to indicate presence of new ipfw interface.
> 
> Modified:
>   projects/ipfw/sys/netpfil/ipfw/ip_fw2.c
> 
> Modified: projects/ipfw/sys/netpfil/ipfw/ip_fw2.c
> ============================================================================
> == --- projects/ipfw/sys/netpfil/ipfw/ip_fw2.c	Sat Oct  4 11:40:35
> 2014	(r272514) +++ projects/ipfw/sys/netpfil/ipfw/ip_fw2.c	Sat Oct  4
> 12:10:32 2014	(r272515) @@ -2874,6 +2874,7 @@ static moduledata_t ipfwmod =
> {
>  #define	IPFW_VNET_ORDER		(IPFW_MODEVENT_ORDER + 2) /* Later still. */
> 
>  DECLARE_MODULE(ipfw, ipfwmod, IPFW_SI_SUB_FIREWALL, IPFW_MODEVENT_ORDER);
> +FEATURE(ipfw_ctl3, "ipfw new sockopt calls");
>  MODULE_VERSION(ipfw, 2);
>  /* should declare some dependencies here */

Would it be better to bump the module version to 3 instead?  Userland programs 
can then use modfind() and modstat() to determine the version.

-- 
John Baldwin