From nobody Sun Oct 23 03:47:05 2022 X-Original-To: freebsd-gecko@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Mw3zD3bQkz4ft6T for ; Sun, 23 Oct 2022 03:46:32 +0000 (UTC) (envelope-from ihor@antonovs.family) Received: from mail.antonovs.family (mail.antonovs.family [100.25.240.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.antonovs.family", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Mw3zC4yxyz3j0C for ; Sun, 23 Oct 2022 03:46:31 +0000 (UTC) (envelope-from ihor@antonovs.family) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=antonovs.family; s=20200215; t=1666496787; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=MRxwsyUad+1p2J5bq6kt30YT1hT2tPy3rEBgdclfViA=; b=8ax6wmvrcdcE/XfPwz7spzvdvhO7NpC/4BI4e5ghn3vUHmuAnVpvwG6ckNhI/wk/WHf8qO 4ugLPkbHpL+v3q2ccDRdBMY0ebnS/gAD5EsCbL3TXKq3HSRb4AKP9Z3F/GD8LqrEYlhFmS JfICkRh25sUnQZQRHhNWS2kJDR1w68Y= Received: by mail.antonovs.family (OpenSMTPD) with ESMTPSA id 4e044fb9 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Sun, 23 Oct 2022 03:46:27 +0000 (UTC) Date: Sat, 22 Oct 2022 20:47:05 -0700 From: Ihor Antonov To: freebsd-gecko@FreeBSD.org Subject: Firefox 106 Broken WebRTC Screencast on wayland Message-ID: <20221023034705.jikcyk4fwye4cvmg@localhost> List-Id: Gecko Rendering Engine issues List-Archive: https://lists.freebsd.org/archives/freebsd-gecko List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-gecko@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 4Mw3zC4yxyz3j0C X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=antonovs.family header.s=20200215 header.b=8ax6wmvr; dmarc=pass (policy=none) header.from=antonovs.family; spf=pass (mx1.freebsd.org: domain of ihor@antonovs.family designates 100.25.240.195 as permitted sender) smtp.mailfrom=ihor@antonovs.family X-Spamd-Result: default: False [-3.50 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[antonovs.family,none]; MID_RHS_NOT_FQDN(0.50)[]; R_SPF_ALLOW(-0.20)[+mx]; R_DKIM_ALLOW(-0.20)[antonovs.family:s=20200215]; MIME_GOOD(-0.10)[text/plain]; ASN(0.00)[asn:14618, ipnet:100.24.0.0/13, country:US]; MIME_TRACE(0.00)[0:+]; MLMMJ_DEST(0.00)[freebsd-gecko@FreeBSD.org]; FROM_EQ_ENVFROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[antonovs.family:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-gecko@freebsd.org]; TO_DN_NONE(0.00)[]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N Hi list, After upgrading to Firefox 106 screensharing functionality on wayland stopped working. Firefox ESR (102) still works. I have traced the breakage to firefox, as no other components of the stack have changed (sway, pipewire, dbus, xdg-desktop-portal, xdg-desktop-portal-wlr) It looks like firefox simply stopped trying to use the screencast functionality - dbus-monitor shows that there are no calls to org.freedesktop.portal.ScreenCast interface. No errors, just no attempts to use it to begin with. Then I compared firefox and firefox-esr ports and noticed that there is a generated webrtc patch [1], [2] Where ESR patch has this line enabled in some cases, non-esr has 0 of these enabled (the patch only removes these lines) DEFINES["WEBRTC_USE_PIPEWIRE"] = True Questions: - could this be a reason why WebRTC screensharing stopped working? - how the patch gets generated? - maybe there is a reason WEBRTC_USE_PIPEWIRE was disabled on latest version? Thanks Ihor [1] https://github.com/freebsd/freebsd-ports/blob/main/www/firefox/files/patch-libwebrtc-generated [2] https://github.com/freebsd/freebsd-ports/blob/main/www/firefox-esr/files/patch-libwebrtc-generated