Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 18 Mar 2017 11:37:04 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 217872] [NEW PORT] graphics/guetzli: Perceptual JPEG encoder
Message-ID:  <bug-217872-13-FDGlzqWRdV@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-217872-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-217872-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217872

Tobias Kortkamp <tobik@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|freebsd-ports-bugs@FreeBSD. |tobik@freebsd.org
                   |org                         |
             Status|New                         |Open
                 CC|                            |tobik@freebsd.org

--- Comment #2 from Tobias Kortkamp <tobik@freebsd.org> ---
Hi Yuri,

some comments inline.

X# Created by: Yuri Victorovich <yuri@rawbw.com>
X# $FreeBSD$
X
XPORTNAME=3D      guetzli
XPORTVERSION=3D   0.170317

Version 1.0 is tagged on GitHub.  Why can't we use it?

XDISTVERSIONPREFIX=3D     v

DISTVERSIONPREFIX is unnecessary if you're not using the
v1.0 tag.

XCATEGORIES=3D    graphics
X
XMAINTAINER=3D    yuri@rawbw.com
XCOMMENT=3D       Perceptual JPEG encoder
X
XLICENSE=3D       APACHE20

Missing LICENSE_FILE

X
XLIB_DEPENDS=3D   libpng.so:graphics/png \
X               libgflags_nothreads.so:devel/gflags
X
XUSE_GITHUB=3D    yes
XGH_ACCOUNT=3D    google
XGH_TAGNAME=3D    b0cf821
X
XUSES=3D          gmake
XCFLAGS+=3D       -I${LOCALBASE}/include
XLDFLAGS+=3D      -L${LOCALBASE}/lib

Remove CFLAGS and LDFLAGS and add USES=3Dlocalbase:ldflags

XPLIST_FILES=3D   bin/guetzli
X
Xdo-install:
X       ${INSTALL_PROGRAM} ${WRKSRC}/bin/Release/guetzli
${STAGEDIR}${PREFIX}/bin
X
X.include <bsd.port.mk>

The build seems to not be verbose.  I suggest adding MAKE_FLAGS=3D verbose=
=3D1 to
make future build failure logs more informative.

This also reveals that -O3 is passed to the build where it shouldn't be.
Maybe also add config=3Ddebug to MAKE_FLAGS.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-217872-13-FDGlzqWRdV>