From owner-cvs-all  Fri Sep 24  3:27:33 1999
Delivered-To: cvs-all@freebsd.org
Received: from gndrsh.dnsmgr.net (GndRsh.dnsmgr.net [198.145.92.4])
	by hub.freebsd.org (Postfix) with ESMTP
	id C0BE914D3D; Fri, 24 Sep 1999 03:26:52 -0700 (PDT)
	(envelope-from freebsd@gndrsh.dnsmgr.net)
Received: (from freebsd@localhost)
	by gndrsh.dnsmgr.net (8.9.3/8.9.3) id DAA02159;
	Fri, 24 Sep 1999 03:23:55 -0700 (PDT)
	(envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>
Message-Id: <199909241023.DAA02159@gndrsh.dnsmgr.net>
Subject: Re: cvs commit: src/contrib/groff/nroff nroff.sh
In-Reply-To: <19990924103343.B28781@scorpion.crimea.ua> from Alexey Zelkin at "Sep 24, 1999 10:33:44 am"
To: phantom@cris.net (Alexey Zelkin)
Date: Fri, 24 Sep 1999 03:23:55 -0700 (PDT)
Cc: ache@FreeBSD.ORG, tejblum@arc.hq.cti.ru (Dmitrij Tejblum),
	committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL54 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

> hi,
> 
> On Thu, Sep 23, 1999 at 05:56:32PM -0700, Rodney W. Grimes wrote:
> 
> > > I regulary look into /usr/share/doc/08.sendmailop/paper.ascii.gz. It is 
> > > effectively created by nroff with pic and eqn preprocessors. The result 
> > > looks funny somewhere, but still quite useful.
> > > 
> > > (I just want to give you both a fact to consider, no more).
> > 
> > An erronious fact at that :-(
> > 
> > The paper.ascii.gz files are created by:
> 
> [dd]
>  
> > Or if you can't see it in the above:
> > 
> > groff -mtty-char -Tascii -e -p -me -o1-
> > 
> > It is created by with groff directly, not with nroff's wrapper.  It would
> > be nice if the glitches casued by -e and -p could be fixed up though when
> > the output format is -Tascii -mtty-char.
> 
> ------------------------------------------------------------------------
> revision 1.16
> date: 1995/01/17 21:36:06;  author: ache;  state: Exp;  lines: +2 -2
> Modify prev. change, pass internal args directly to groff,
> if PRINTER == ascii, because nroff shell script strip off
> some groff flags
> ------------------------------------------------------------------------
> revision 1.15
> date: 1995/01/17 21:27:30;  author: ache;  state: Exp;  lines: +5 -1
> Call nroff, if PRINTER == ascii
> ------------------------------------------------------------------------
> 
> Is this commit logs on bsd.doc.mk enough to prove that you argument isn't
> correct. And I was right with my commit ? Anyway -- it would be interesting
> to listen ache's opinions. If Andrey don't agree to my commit I'll back out it.

Actually it proves just the opposite, did you actually look at what
the final results of the combination of 1.15 and 1.16 is (ache tried
to use nroff, but found that to be a bad idea and fixed up the
call to use groff with the correct arguements):

gndrsh:root {614}# cvs diff -c -r1.14 -r1.16 bsd.doc.mk | more
Index: bsd.doc.mk
===================================================================
RCS file: /home/ncvs/src/share/mk/bsd.doc.mk,v
retrieving revision 1.14
retrieving revision 1.16
diff -c -r1.14 -r1.16
*** bsd.doc.mk  1995/01/14 19:49:54     1.14
--- bsd.doc.mk  1995/01/17 21:36:06     1.16
***************
*** 1,5 ****
  #     from: @(#)bsd.doc.mk    5.3 (Berkeley) 1/2/91
! #     $Id: bsd.doc.mk,v 1.13 1995/01/14 07:51:04 jkh Exp $
  
  PRINTER?=     ps
  
--- 1,5 ----
  #     from: @(#)bsd.doc.mk    5.3 (Berkeley) 1/2/91
! #     $Id: bsd.doc.mk,v 1.15 1995/01/17 21:27:30 ache Exp $
  
  PRINTER?=     ps
  
***************
*** 10,16 ****
--- 10,20 ----
  INDXBIB?=     indxbib
  PIC?=         pic
  REFER?=               refer
+ .if ${PRINTER} == "ascii"
+ ROFF?=          groff -Wall -mtty-char ${TRFLAGS} ${MACROS} -o${PAGES}
+ .else
  ROFF?=                groff ${TRFLAGS} ${MACROS} -o${PAGES}
+ .endif
  SOELIM?=      soelim
  TBL?=         tbl


> 
> Peace ? :-)

I'm just trying to make sure we are not walking down a slippery slope
that may introduce more problems that it really fixes.  I have no
problems with nroff trying to deal with -e -t and -p so long as it
does it _correctly_.  But POLA says if nroff produces bad output
someone down the road some day is going to file a PR against it.

-- 
Rod Grimes - KD7CAX - (RWG25)                    rgrimes@gndrsh.dnsmgr.net


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message