From owner-cvs-src@FreeBSD.ORG  Sat Sep 30 16:20:44 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 742E216A416;
	Sat, 30 Sep 2006 16:20:44 +0000 (UTC)
	(envelope-from jhay@meraka.csir.co.za)
Received: from zibbi.meraka.csir.co.za (zibbi.meraka.csir.co.za [146.64.24.58])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E34FF43D68;
	Sat, 30 Sep 2006 16:20:40 +0000 (GMT)
	(envelope-from jhay@meraka.csir.co.za)
Received: by zibbi.meraka.csir.co.za (Postfix, from userid 3973)
	id 7DCA033C9C; Sat, 30 Sep 2006 18:20:39 +0200 (SAST)
Date: Sat, 30 Sep 2006 18:20:39 +0200
From: John Hay <jhay@meraka.org.za>
To: Hajimu UMEMOTO <ume@FreeBSD.org>
Message-ID: <20060930162039.GA59699@zibbi.meraka.csir.co.za>
References: <200609301408.k8UE8vpM069161@repoman.freebsd.org>
	<ygewt7l1l1c.wl%ume@mahoroba.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ygewt7l1l1c.wl%ume@mahoroba.org>
User-Agent: Mutt/1.4.2.1i
Cc: John Hay <jhay@FreeBSD.org>, src-committers@FreeBSD.org,
	cvs-all@FreeBSD.org, cvs-src@FreeBSD.org
Subject: Re: cvs commit: src/sys/netinet6 nd6.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 30 Sep 2006 16:20:44 -0000

On Sat, Sep 30, 2006 at 11:33:35PM +0900, Hajimu UMEMOTO wrote:
> jhay>   FreeBSD src repository
> 
> jhay>   Modified files:
> jhay>     sys/netinet6         nd6.c 
> jhay>   Log:
> jhay>   My previous commit broke "route add -inet6 <network_addr> -interface gif0".
> jhay>   Fix that by excluding point-to-point interfaces.
>   
> > -		} else if (req == RTM_ADD && SDL(gate)->sdl_alen == 0) {
> > +		} else if (req == RTM_ADD && SDL(gate)->sdl_alen == 0 &&
> > +		    (ifp->if_flags & (IFF_POINTOPOINT | IFF_LOOPBACK)) == 0) {
> > 			ln->ln_state = ND6_LLINFO_INCOMPLETE;
> 
> Umm, it seems still there is a problem.  We are using -interface not
> only for point-to-point interface and loopback.
> I'm not sure but can we check `(rt->rt_flags & RTF_HOST) != 0', here?

That would work better yes. Is there a reason you feel unsure about it?
Or is it just a case of not having tested it?

John
-- 
John Hay -- John.Hay@meraka.csir.co.za / jhay@FreeBSD.org