From owner-freebsd-current@FreeBSD.ORG Sat Nov 5 12:52:26 2005 Return-Path: X-Original-To: freebsd-current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D439216A41F for ; Sat, 5 Nov 2005 12:52:26 +0000 (GMT) (envelope-from keramida@linux.gr) Received: from nic.ach.sch.gr (nic.sch.gr [194.63.238.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3916343D4C for ; Sat, 5 Nov 2005 12:52:24 +0000 (GMT) (envelope-from keramida@linux.gr) Received: (qmail 11059 invoked by uid 207); 5 Nov 2005 12:52:23 -0000 Received: from keramida@linux.gr by nic by uid 201 with qmail-scanner-1.21 (sophie: 3.04/2.30/3.97. Clear:RC:1(81.186.70.43):. Processed in 0.560509 secs); 05 Nov 2005 12:52:23 -0000 Received: from dialup43.ach.sch.gr (HELO flame.pc) ([81.186.70.43]) (envelope-sender ) by nic.sch.gr (qmail-ldap-1.03) with AES256-SHA encrypted SMTP for ; 5 Nov 2005 12:52:22 -0000 Received: from flame.pc (flame [127.0.0.1]) by flame.pc (8.13.4/8.13.4) with ESMTP id jA5Cq7Qq001479; Sat, 5 Nov 2005 14:52:07 +0200 (EET) (envelope-from keramida@linux.gr) Received: (from keramida@localhost) by flame.pc (8.13.4/8.13.4/Submit) id jA5Cq73S001478; Sat, 5 Nov 2005 14:52:07 +0200 (EET) (envelope-from keramida@linux.gr) Date: Sat, 5 Nov 2005 14:52:07 +0200 From: Giorgos Keramidas To: Gleb Smirnoff Message-ID: <20051105125207.GC1219@flame.pc> References: <20051104092724.GA33945@xor.obsecurity.org> <436B885B.6010609@freebsd.org> <20051104163526.GC82727@flame.pc> <200511041833.30955.thierry@herbelot.com> <436BA8B5.9070104@freebsd.org> <20051105003420.GM91530@cell.sick.ru> <20051105034105.GA906@flame.pc> <20051105080116.GR91530@cell.sick.ru> <20051105084924.GT91530@cell.sick.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051105084924.GT91530@cell.sick.ru> Cc: freebsd-current@FreeBSD.org, Andre Oppermann , sam@FreeBSD.org, thierry@herbelot.com Subject: Re: panic: mb_dtor_pack: ref_cnt != 1 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Nov 2005 12:52:27 -0000 On 2005-11-05 11:49, Gleb Smirnoff wrote: > One more update. Since I have removed this block: > > if (*(m->m_ext.ref_cnt) == 0) > *(m->m_ext.ref_cnt) = 1; > > I have also altered KASSERT in mb_dtor_pack(). I don't like > inventing an incorrect invariant check and then adding helpers > to avoid it being triggered. > > [--- mbuma.patch ---] Very nice, thanks! I'll build the next kernel with the updated patch, later today.