From owner-cvs-src@FreeBSD.ORG  Sat Apr 26 12:55:33 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 758)
	id 2AA6B106567B; Sat, 26 Apr 2008 12:55:33 +0000 (UTC)
Date: Sat, 26 Apr 2008 12:55:33 +0000
From: Kris Kennaway <kris@FreeBSD.org>
To: Roman Divacky <rdivacky@FreeBSD.org>
Message-ID: <20080426125533.GD47671@hub.freebsd.org>
References: <200804242208.m3OM8a12040177@repoman.freebsd.org>
	<20080425130459.GA70110@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080425130459.GA70110@freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-src@FreeBSD.org, Kris Kennaway <kris@FreeBSD.org>,
	src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_descrip.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 26 Apr 2008 12:55:33 -0000

On Fri, Apr 25, 2008 at 03:04:59PM +0200, Roman Divacky wrote:
> On Thu, Apr 24, 2008 at 10:08:36PM +0000, Kris Kennaway wrote:
> > kris        2008-04-24 22:08:36 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/kern             kern_descrip.c 
> >   Log:
> >   fdhold can return NULL, so add the one remaining missing check for this
> >   condition.
> 
>         fdp = fdhold(p);
> +       if (fdp == NULL)
> +               return (0);
>         PROC_UNLOCK(p);
> 
> I think you leak the PROC lock here...

You're right, I mis-merged :/

Kris

--
In God we Trust -- all others must submit an X.509 certificate.
    -- Charles Forsythe <forsythe@alum.mit.edu>