Date: Sat, 26 Apr 2008 12:55:33 +0000 From: Kris Kennaway <kris@FreeBSD.org> To: Roman Divacky <rdivacky@FreeBSD.org> Cc: cvs-src@FreeBSD.org, Kris Kennaway <kris@FreeBSD.org>, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_descrip.c Message-ID: <20080426125533.GD47671@hub.freebsd.org> In-Reply-To: <20080425130459.GA70110@freebsd.org> References: <200804242208.m3OM8a12040177@repoman.freebsd.org> <20080425130459.GA70110@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 25, 2008 at 03:04:59PM +0200, Roman Divacky wrote:
> On Thu, Apr 24, 2008 at 10:08:36PM +0000, Kris Kennaway wrote:
> > kris 2008-04-24 22:08:36 UTC
> >
> > FreeBSD src repository
> >
> > Modified files:
> > sys/kern kern_descrip.c
> > Log:
> > fdhold can return NULL, so add the one remaining missing check for this
> > condition.
>
> fdp = fdhold(p);
> + if (fdp == NULL)
> + return (0);
> PROC_UNLOCK(p);
>
> I think you leak the PROC lock here...
You're right, I mis-merged :/
Kris
--
In God we Trust -- all others must submit an X.509 certificate.
-- Charles Forsythe <forsythe@alum.mit.edu>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080426125533.GD47671>