From nobody Mon Nov 24 04:00:51 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dFBv75WNnz6Hym1 for ; Mon, 24 Nov 2025 04:00:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dFBv74nkWz3YkB for ; Mon, 24 Nov 2025 04:00:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763956851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Vha3MCOwfmXj0uVyc5dT09OjMMASdf7/fxCPXLZ5TlA=; b=wRO/B3T/OTi4zfm5Q3OEDDoqdPP4mrxHEkS6pmkxxrZa5hmeFHMUpONG9IEUnxNqX0MzWi s0FG61NTRNkolrfbm5WyY+W8zKpU0qsFTaAv0xRlOfG10jNvJNer4RTpX72WQN+xl7r8O/ r/2/IK81SaWBVqjGTTzfLZwQVlnYjn3eHGzQWPJI9cSJdw3V7n6+EXiFVzLp8BpVaek8aA I6BkU0/0WBAMX+hlnwks6L3WCGRAXTGESCU90wWi3avyzuF/mCH+Ug58fW+MM5qjlBqbRX fvYUFo8MYCZDmSiip2mGJfGP/Y4tbr3fAFZUJj97wi5xMOF/e/hmiLdWKmhNtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763956851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Vha3MCOwfmXj0uVyc5dT09OjMMASdf7/fxCPXLZ5TlA=; b=LVSDAeasOGnSZ+f7FE1+ppbLM5yfm4M97ZPOprjiXkGhmVpciUcgzRdt08zlMtZ/EjAtzj 1qfTfpC2B0gOxh3v0tTzlfbsWphPBL4AzUP30lzSPqqHADAqGsxo0g6JQ6N0sQNrlgk82y qCB20b0Pl5BkC0rYdcvugQsZpw9XIxApe31u9JcSIWy7wJ8NkzvYzQk3T92i+kZuCVsQ+W M5LRcwAkzhUwc2qgCoPrfbs3Gfnn09s6gU2/4Y0kiL+ny+gjJJc5YUle7a4xNi9nSgKWSV 1cgwXnHos+ukHKP4A+Sc8JmmXxGkZGxdnKrvIor8a7flxSVmW5QlWL7uJb8HBQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1763956851; a=rsa-sha256; cv=none; b=bNr50Q7jnCni1mpyvxf+JUOrgxZjdMfuvlPPovh/C8HGiOHw27zhyqVEOR4qiTT6SnTvU8 ALA/sc2SBRZ2Pd14Ja8/7c3cWShKVNWnyKTlRl7MZkJ6rPa0h6YKRgECK/Pr5ABEkxdqAI BMOq1xU1SM1IxK9encaVHjydsbiLBo03B6KgjVdYiE9B3NkWMX2Jicw4itRqeFrENMtYit inuCf8rnvk0oaIi6HVfN/TY+ynpx5w3CVefy/rxEWGd2s9g7zGVcJ3H60Feo5eizar8b0E l5SZ/51NNeOThXBn+qkzuu5QjIUL7D7ofoJ2rKdyKpGTA9VXsUezf5xt1ZGJfA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dFBv7443mzyNL for ; Mon, 24 Nov 2025 04:00:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 35d06 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 24 Nov 2025 04:00:51 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Cy Schubert Subject: git: d9c345c9d3ca - stable/13 - ntpd: Fix segfault when same IP on multiple interfaces List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: d9c345c9d3cac00d055ca748e43b308861529a01 Auto-Submitted: auto-generated Date: Mon, 24 Nov 2025 04:00:51 +0000 Message-Id: <6923d873.35d06.150cfe7e@gitrepo.freebsd.org> The branch stable/13 has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=d9c345c9d3cac00d055ca748e43b308861529a01 commit d9c345c9d3cac00d055ca748e43b308861529a01 Author: Cy Schubert AuthorDate: 2025-11-21 00:16:04 +0000 Commit: Cy Schubert CommitDate: 2025-11-24 04:00:43 +0000 ntpd: Fix segfault when same IP on multiple interfaces Use the protype socket to obtain the IP address for an error message. Using the resultant socket address, a NULL because create_interface() had failed, results in SIGSEGV. To reproduce this bug, ifconfig bridge100 create ifconfig bridge100 10.10.10.10/24 ifconfig bridge101 create ifconfig bridge101 10.10.10.10/24 ntpd -n PR: 291119 (cherry picked from commit ac1f48b4a7be104d222dea60f1da946fcb345fb1) --- contrib/ntp/ntpd/ntp_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/ntp/ntpd/ntp_io.c b/contrib/ntp/ntpd/ntp_io.c index 9c4f6c1553e3..97b85ee83e36 100644 --- a/contrib/ntp/ntpd/ntp_io.c +++ b/contrib/ntp/ntpd/ntp_io.c @@ -1923,7 +1923,7 @@ update_interfaces( msyslog(LOG_ERR, "cannot bind address %s", - stoa(&ep->sin)); + stoa(&ep2->sin)); } free(ep2); }