From owner-soc-status@freebsd.org Tue Jun 6 07:58:28 2017 Return-Path: Delivered-To: soc-status@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3A808BF92D6 for ; Tue, 6 Jun 2017 07:58:28 +0000 (UTC) (envelope-from milesfertel@college.harvard.edu) Received: from mail-wr0-x22c.google.com (mail-wr0-x22c.google.com [IPv6:2a00:1450:400c:c0c::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DE1D282435 for ; Tue, 6 Jun 2017 07:58:27 +0000 (UTC) (envelope-from milesfertel@college.harvard.edu) Received: by mail-wr0-x22c.google.com with SMTP id g76so50170515wrd.1 for ; Tue, 06 Jun 2017 00:58:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=college-harvard-edu.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=AcGIfsKWjf8cYJtXXHUuX1brSSkq8JEabs2vyWzMfZE=; b=vKnS2lNaYQFe/j+B3PFipJzPbJ/ibC1bJ+BKb9/+Im3O2JC3fdtaFjD3RXiSIRSoZj 7HG6gaprO/ygpbKpW24IJC6Od+uhOXg7g3iLQJfVtGbSZu1LC6JD5DzJiuNnQaXdbbcp oTNScR1siXz/FavOA3bi4x80PxOCXLbNOQejOVTSIQM0CCGPfHZP+ejVK3dp8eMZr9VZ Cv5JpjsXCecVPb+KC8m4+J625v2w1qzLqc0HkS6RZD+wxT8TDMIq9WyLspqeWtWCgbR+ jKdDusdozl6yHb9yKtKbNDayEDmgA2O/86deQL7SSXkiBWeMqIRHYsliL2VBMZJE+WWm 4zAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=AcGIfsKWjf8cYJtXXHUuX1brSSkq8JEabs2vyWzMfZE=; b=CQH9z+x5t5LgEyb21y5b1jljmP2prZ6UPM+73w35BybB4LrdpGspT5BdHOlFtHD3ud u8euYmaUIQnPj2ux86JzsMDNAV4KAQTTaFIz/qoHuz3lLhxodFXZui3vDHQ/y/mbsPA4 ZsTQ7TJoNkPcb2UIIKLUj9+tOreH99A3hfS5DFok5xVTJ+QmjVWJfspU87X3psooYI3o pfkgw+78ziZiqkOrh+CV2x3uqnfRisRafw3wkoQI94bE3i6r+fEy34PIUrx9WoPoQKSj cDJRMJ/EDg+/GQtY5VKVPcV0wQJUg9emqYhZdfbYyBeIwC45c2veEdsYtiJ4RaJqomq1 9R9A== X-Gm-Message-State: AODbwcA6mgvyuyAgEKth9sixyDGznsJ9QOv5Sw0GoKlolc8Pu06zq79M 8QBS4n4ZonuJ5kGAPXN2GPozVgq7b/hh X-Received: by 10.223.138.194 with SMTP id z2mr18720715wrz.66.1496735906293; Tue, 06 Jun 2017 00:58:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.173.76 with HTTP; Tue, 6 Jun 2017 00:58:25 -0700 (PDT) In-Reply-To: <20170606004130.GC14665@spindle.one-eyed-alien.net> References: <20170606004130.GC14665@spindle.one-eyed-alien.net> From: Miles Fertel Date: Tue, 6 Jun 2017 09:58:25 +0200 Message-ID: Subject: Re: Week 1 Update: Mergesort Tests To: Brooks Davis Cc: soc-status@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: soc-status@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Summer of Code Status Reports and Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jun 2017 07:58:28 -0000 Made it public! Here's the review: https://github.com/milesfertel/GSOC-Mergesort/pull/1/commits/9297e92f08a7f318ec3e6e2e2377d78bfa763dbf I'm not sure if you'll see the comments on the pull request unless you're logged in. Let me know if that's a problem. -Miles On Tue, Jun 6, 2017 at 2:41 AM, Brooks Davis wrote: > I got an invite from github, but even when I was definitely logged in, I > got 404 errors accessing it. > > As a practical matter, your repo needs to be public as that's part of the > terms from Google. > > -- Brooks > > On Mon, Jun 05, 2017 at 09:53:00AM -0400, Miles Fertel wrote: > > Hey Brooks, > > > > Just wanted to let you know that I've pushed my first week of work to the > > github repo and added you as a collaborator. I've submitted a pull > request > > from the dev branch to the master and started a review with a question or > > two. > > > > I've edited mergesort_test.c to have a good first implementation, > including > > tests for: > > > > - Trivial arrays > > - Sorted arrays > > - Partially sorted arrays > > - Randomly generated arrays > > - Arrays with char elements > > > > I've built this up on top of the previous implementation, so the Kyuafile > > is the same. I ran the implementation locally with atf and kyua and the > > current mergesort behaves as expected, succeeding all all tests except > for > > the small element test. When my improved algorithm is complete, that > should > > pass as well. > > > > Please let me know if there's anything I could improve. > > > > - Miles >