From nobody Sat Nov 2 05:16:19 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XgQtv4936z5blcq; Sat, 02 Nov 2024 05:16:23 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XgQtv1N2mz4RVZ; Sat, 2 Nov 2024 05:16:22 +0000 (UTC) (envelope-from rpokala@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730524583; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uvzzMskhkzRf3RIF9x4dsLLuauyJ2lardfg8J7OagCw=; b=mWy75DovRv/XIFQFFBecHdbRo7PGJK9tHk2WK8zqCRZTv0wKkDo1xQmyVb9K7ZwjpGM98T FTgKzUEy40AnfUsiJFCr5FtPtq7APCyWKZtoSKAdAKPVgmqmTY5NWlalY/bM+djm5JfI3T wZ5GsI4t8rTWDsPs3AxtO6C8RZskdZLiUxdrxrGQevBRnklHCfP9XQjlvClcK0eSkhJAuU KicwPC4N8V+eE2qKlBYOt3MPLmluknPuol82plmzrKWfbfT6gVPm721+AhJkwGphnWllE/ TbMxYe31tLthM2dIEtUur62i99opzodjpGZgvNYtNXsr9we78c6mzFOr2ij+bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730524583; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uvzzMskhkzRf3RIF9x4dsLLuauyJ2lardfg8J7OagCw=; b=UsfxvBlAyqSNoEHVQ4yvex6PO2UYx1kyekaMp19TUZ57eLBy4+0xO0OnSFCF7yJcbgaTo3 dQWxvqqvrjvObzf90vTtqUnQAmWSfEbXlklv7HtOFAZbLx0UIHynSK5w5rli+9A+Vpikx1 tW2WJJw8Iyp4ZW2YEKbEqRTfMNkJ20b1cT5YqMTNHNaWtsaxYsBxTDjImjvsUPbQjdtcSN 0YtkiRFo/fOvX8/kvInm3CrDOQIfu07NCkBcCREAgFzapgAP06NUZDS0vLws8SBkKVNfEU lndcOcZ8/HRt1iy61keUQsFY+C7j3dJvyHX0zYRpGUjI3nUiWUTVEABUuCbqIQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730524583; a=rsa-sha256; cv=none; b=ZQdECxXzbHUnnSuWFakFOyGbOFaHco2fNve11/QklhHVCitTpUBEimKbXXw2dUp1vS5h3T V3iRkosZUYRFa3fcT81yEaQS+3SBVeq0cjt9qJC2tH8Y9sfVRHbA3ugBpZt4fGHMs7k3ch hdel9+LD8trvCnYtJkj5mt6WQM5rlCTGzc17Dp0fW8JrgC8j6Ruyg/Kw7WFjFZabjzxdai l9dPUSE+kcr+I+pEjeaqrbEqCqPBrFIYeEiw2n5m34uU6VHrEUQBZ4uwTa/IeFBAzlHDq2 7hRuJik4s/gZr/lAu8J/qaKTXlWbEpmB8/cpkqWrX2n9sEmJ52yNkIg6Ie3q9w== Received: from [192.168.1.10] (c-73-231-46-254.hsd1.ca.comcast.net [73.231.46.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id 4XgQtt29G3zPwm; Sat, 2 Nov 2024 05:16:22 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/16.90.24102719 Date: Fri, 01 Nov 2024 22:16:19 -0700 Subject: Re: 6540ac118473 - main - modules: gpioaei only on ACPI-supporting archs From: Ravi Pokala To: Colin Percival , , , Message-ID: <0FC811CD-24E2-48E0-8F06-C75CFEB3FBBE@panasas.com> Thread-Topic: 6540ac118473 - main - modules: gpioaei only on ACPI-supporting archs References: <202410312247.49VMl6TW031342@gitrepo.freebsd.org> <6E1A6F2E-C236-4A23-BFD2-8D917A02D5C2@panasas.com> In-Reply-To: List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: quoted-printable Yes, it was the previous change, not this one. And yes, simply adding 'acpi= _if.h' to the Makefile did the trick. I went ahead and committed it: 9709bda= 03cd0 Thanks, Ravi (rpokala@) =EF=BB=BF-----Original Message----- From: > on behalf of Colin Percival > Date: Friday, November 1, 2024 at 19:13 To: Ravi Pokala >, >, >, > Subject: Re: 6540ac118473 - main - modules: gpioaei only on ACPI-supporting= archs On 11/1/24 18:34, Ravi Pokala wrote: > This seems to have broken arm64.LINT-FDT: >=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > % less _.arm64.LINT-FDT > ... > -------------------------------------------------------------- >>>> stage 3.1: building everything > -------------------------------------------------------------- > In file included from /usr/home/rpokala/freebsd/src/clean-main/sys/dev/gp= io//gpioaei.c:37: > /usr/home/rpokala/freebsd/src/clean-main/sys/dev/acpica/acpivar.h:34:10: = fatal error: 'acpi_if.h' file not found > 34 | #include "acpi_if.h" > | ^~~~~~~~~~~ > 1 error generated. > *** [gpioaei.o] Error code 1 >=20 > make[8]: stopped making "all" in /usr/home/rpokala/freebsd/src/clean-main= /sys/modules/gpio/gpioaei Oops. It was probably the earlier commit which broke it, but I'm clearly not good at kernel modules. Can you check if adding "acpi_if.h" to SRCS in src/sys/modules/gpio/gpioaei/Makefile fixes the problem? --=20 Colin Percival FreeBSD Release Engineering Lead & EC2 platform maintainer Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid