Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 27 Feb 2020 19:40:21 +0000 (UTC)
From:      Edward Tomasz Napierala <trasz@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r358403 - head/sys/compat/linux
Message-ID:  <202002271940.01RJeLxq036245@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: trasz
Date: Thu Feb 27 19:40:20 2020
New Revision: 358403
URL: https://svnweb.freebsd.org/changeset/base/358403

Log:
  Make linuxulator warn about unsupported getsockopt/setsockopt flags.
  
  MFC after:	2 weeks
  Differential Revision:	https://reviews.freebsd.org/D23791

Modified:
  head/sys/compat/linux/linux_socket.c

Modified: head/sys/compat/linux/linux_socket.c
==============================================================================
--- head/sys/compat/linux/linux_socket.c	Thu Feb 27 19:35:17 2020	(r358402)
+++ head/sys/compat/linux/linux_socket.c	Thu Feb 27 19:40:20 2020	(r358403)
@@ -1451,10 +1451,13 @@ linux_setsockopt(struct thread *td, struct linux_setso
 		name = -1;
 		break;
 	}
-	if (name == -1)
+	if (name == -1) {
+		linux_msg(curthread,
+		    "unsupported setsockopt level %d optname %d",
+		    args->level, args->optname);
 		return (ENOPROTOOPT);
+	}
 
-
 	if (name == IPV6_NEXTHOP) {
 		len = args->optlen;
 		error = linux_to_bsd_sockaddr(PTRIN(args->optval), &sa, &len);
@@ -1546,8 +1549,12 @@ linux_getsockopt(struct thread *td, struct linux_getso
 		name = -1;
 		break;
 	}
-	if (name == -1)
+	if (name == -1) {
+		linux_msg(curthread,
+		    "unsupported getsockopt level %d optname %d",
+		    args->level, args->optname);
 		return (EINVAL);
+	}
 
 	if (name == IPV6_NEXTHOP) {
 		error = copyin(PTRIN(args->optlen), &len, sizeof(len));



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202002271940.01RJeLxq036245>