From owner-freebsd-bugs@FreeBSD.ORG Wed Mar 31 00:40:50 2010 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3815D106566B for ; Wed, 31 Mar 2010 00:40:50 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-yw0-f171.google.com (mail-yw0-f171.google.com [209.85.211.171]) by mx1.freebsd.org (Postfix) with ESMTP id C506B8FC08 for ; Wed, 31 Mar 2010 00:40:49 +0000 (UTC) Received: by ywh1 with SMTP id 1so6287554ywh.3 for ; Tue, 30 Mar 2010 17:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:received:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=3pRew74qdOzyVxNTCCK5/bZIwVA0A9a1RqDd1qN78KA=; b=CCfGLMACawkxxBSu6xidhmJix59r24GMmNHeN3t1g9Zzs72RSn8jH9KyZN6ZpjXXEz K9BZ36chwdCkUBFesg429QJ4yeuEg6AyUkJUri0ggN//oHjsFdDrIE/dYRnJj6ePBi+V LgyqUfJxiPvlNLvQKNEzQl7mKHzjIjO9fzzMY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=bgu0cxTcpavwynBThRmOF9Sp6uxFRe79sOOhmV+LXnU4lIxKgtw3OGNBtQOUTXBXvT 0+WjekncldXRRSCJcDQDN4lf36eWdJxKrLXdw3nhVwCzld3RLMrZmxkjEguWs6QQXqdM hYr9NVs0HOHNt/mOBQGS7X3vIhap67wMhEWiM= MIME-Version: 1.0 Sender: yanegomi@gmail.com Received: by 10.231.173.195 with HTTP; Tue, 30 Mar 2010 17:40:48 -0700 (PDT) In-Reply-To: <20100331060503.G1425@besplex.bde.org> References: <201003300830.o2U8U93Y096013@freefall.freebsd.org> <20100331034500.O1425@besplex.bde.org> <20100331060503.G1425@besplex.bde.org> Date: Tue, 30 Mar 2010 17:40:48 -0700 X-Google-Sender-Auth: ca4da8c141ecfdb8 Received: by 10.101.152.19 with SMTP id e19mr4521542ano.98.1269996048656; Tue, 30 Mar 2010 17:40:48 -0700 (PDT) Message-ID: <364299f41003301740m4ca73398v9aadcc87e53a4628@mail.gmail.com> From: Garrett Cooper To: Bruce Evans Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-bugs@freebsd.org Subject: Re: bin/144411: [patch] mtree(8) doesn't reject non-regular files for -X X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Mar 2010 00:40:50 -0000 On Tue, Mar 30, 2010 at 12:12 PM, Bruce Evans wrote: > On Wed, 31 Mar 2010, Bruce Evans wrote: > >> On Tue, 30 Mar 2010, Garrett Cooper wrote: >> >>> Hi, >>> =A0 =A0I'm not 100% satisfied with this patch now. Looking back it fail= s >>> the following case: >>> >>> =A0 =A0 -P =A0 =A0Do not follow symbolic links in the file hierarchy, i= nstead >>> con- >>> =A0 =A0 =A0 =A0 =A0 sider the symbolic link itself in any comparisons. = =A0This is the >>> =A0 =A0 =A0 =A0 =A0 default. >> >> -P should have the same semantics and description in all utilities. =A0T= he >> description should not have grammar errors like the above (comma splice)= . >> ... >> I now see that the grammar error is from the original version of mtree(1= ), >> and is probably one of the things you don't like. =A0mtree also has -L, = but >> not -R or -P or -h. =A0It is not clear how any utility that traverses tr= ees >> can work without a full complement of -[HLPR] or how any utility that >> ... > > Looking at the actual patch, I now see that it is about a completely > different problem. =A0You would only need to understand the amount of > brokenness of -P to see if you need to use lstat(). =A0I think -P is so > broken that mtree on symlinks doesn't work at all and not using lstat() > would be safest. Hmmm... so I take it that this is actually the first step in many to fixing this underlying problem? I suppose I should be opening bugs for all of the itemized issues that you see in mtree(8) so someone can submit patches to fix the utility? > The patch has some style bugs. Please expound on this -- I want to improve my style (without having to rewrite the entire program of course) -- so that it conforms more to the projects overall style rules; of course there are some cases where I can't readily do that (like pkg_install -- ugh), but I'll do my best to make sure that the rules are withheld. Thanks :), -Garrett