From owner-svn-src-head@freebsd.org Thu Dec 5 18:16:04 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 122411CFEE1 for ; Thu, 5 Dec 2019 18:16:04 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47TP6W4qkGz4V3D for ; Thu, 5 Dec 2019 18:16:03 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1575569761; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=JjGFcct1oaiFH4PyJdII9vr2G7p7OUTG0bs8MdmUXOQgJ0Ec1yXhpycitkQWWdg5q0zeXEuDlN9yA kqpxR3Qp7y0elBzcfKoiHkup8ZkfiGL5CLVG6wCwgCHndNE+T3/8Pvs9p8T6lGswEMpA7tSNy1NFZT HqaLp/74Jq84aXo7olfPhJb8lOL4cMq06/Ufr/4h6Y9Ygr96GjjUBXevtyASypoAvOnvvxWaQZWZv3 XBfbWEFl+u6/eEZ3bemI291jMxBVa+0hN42UUVFlhFfvotbuXOMN12O/1xpwlQm2eBKmM92kPeA9LV gZj2cC4NAiT7v4nPVCMqlVvJgl9/aqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=byI02FFAuuBPCD5z+MwDdMDQrYvzLz5oq9XMWQ+wfoc=; b=aSVPKRHIw6bt9D9ssb8A7jllLmXCzjZQT/9+R3hPdwu3h2ZID/Vffs2mbhkaL2uhUxYVv0UsHSCm0 lRO9aT9zKh7DTAbPPJZt1aoVR9pQ5/NYao+l0Z+jJJzoetRFd3mteFjQWf58z4CwjuztpbIysL7Jtx qWftLR9VUDK/hHMOLnWO1TJKlJ4A0U8DkSvaA7B0CoGc15lPEzKRKoGThHpMaU61Yy6/wrBQ0vgRhC MiEigKET02mwUZ3NAqpEBHd53+8XNiFifqMInuC93Tf+RliOq+1UqviPvZ3jM8g/T227XMpZjHh1F0 vIv5915LgtmaovcEWoyLUfTQK/VWBMg== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=byI02FFAuuBPCD5z+MwDdMDQrYvzLz5oq9XMWQ+wfoc=; b=sog+3nazyEp1wz/dB8Ilc7M3zgBio0Ic7ghiC7ozx54EfR+eoVJ301Kmrx1T+UpOkvi78Q7+f52Cv xvt+AxvOWQTfTnTqKh3FaHEjVEJZoHSkxNVdhwk/TDAeB8q9aTw7pd9g1Bzh1tvJtbl6nmhzyQPyjS fBRVBLpjZDRlCW65zzHwLqpgnMaTd0uYrgjN/pyFBzK9EbtN5k3yAeoreWj91CR31lhB/EogbYiHgo kK0KisxYYR5rdKlhFyjhdjG766QGOLmWQb5OKvqgMlT2yV2Gd++li65iW6gMKn9G1Lyl7t5D3bI0Bu kJaV1CfATChL6O99z7XT2VnOEMYavBw== X-MHO-RoutePath: aGlwcGll X-MHO-User: 49692a5a-178b-11ea-b80c-052b4a66b6b2 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id 49692a5a-178b-11ea-b80c-052b4a66b6b2; Thu, 05 Dec 2019 18:16:00 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id xB5IFwfr008118; Thu, 5 Dec 2019 11:15:58 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <2db52a541d0a48ec0e706de2fb4605749f9c4fa4.camel@freebsd.org> Subject: Re: svn commit: r355407 - head/sys/fs/tmpfs From: Ian Lepore To: Enji Cooper , Konstantin Belousov Cc: Kubilay Kocak , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Thu, 05 Dec 2019 11:15:58 -0700 In-Reply-To: <80859C2E-1973-4E89-BAD2-5586CC683504@gmail.com> References: <20191205133544.GE2744@kib.kiev.ua> <80859C2E-1973-4E89-BAD2-5586CC683504@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 47TP6W4qkGz4V3D X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.96 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.98)[-0.982,0]; NEURAL_HAM_LONG(-0.98)[-0.981,0]; ASN(0.00)[asn:16509, ipnet:54.186.0.0/15, country:US] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Dec 2019 18:16:04 -0000 On Thu, 2019-12-05 at 10:05 -0800, Enji Cooper wrote: > > On Dec 5, 2019, at 05:36, Konstantin Belousov > > wrote: > > ... > > > > Could you elaborate on the why/rationale? > > > > > > Is there memory wastage/duplication, bug(s), performance or > > > development/maintenance benefit? > > > > Each mount/unmount of tmpfs created and destroyed two zones, as it > > is > > easy to see from the patch. > > Commit messages should provide helpful summaries of changes. Having > to look at and understand the patch requires domain knowledge which > the reader may or may not have. Kubilay’s request seems valid to me. > > -Enji I agree. You read the diff to see the details of what changed. You read the commit message to see why. -- Ian