From owner-freebsd-hackers@FreeBSD.ORG Thu Sep 4 13:52:58 2008 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 71060106567E for ; Thu, 4 Sep 2008 13:52:58 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from ey-out-2122.google.com (ey-out-2122.google.com [74.125.78.24]) by mx1.freebsd.org (Postfix) with ESMTP id EDBC08FC1E for ; Thu, 4 Sep 2008 13:52:57 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: by ey-out-2122.google.com with SMTP id 6so1340116eyi.7 for ; Thu, 04 Sep 2008 06:52:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:date:from:to:cc :subject:message-id:references:mime-version:content-type :content-disposition:in-reply-to:user-agent:sender; bh=MqNQCJJPD3z8st+z6k6W80zbKl56rdgMbsg6bwvE9CQ=; b=cGfUqXdzikyS22VZfmLx50X0VPx7AQPpt0RON4KNT++eSMSnGPJ8USB+GDv8w1SXb+ /O9T2joJO5M6Fdpsbra1JCaYf2qYYQXj3Ljhy/2HxuEGXxXYutytlkhkwmzynfwVDIPY ZTTZddDy51lQHqgTg2uolmCLfR7+QZRTx7dJg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent:sender; b=J/lclCsEBxD11SRWSwb6FnBtvmu+3bpMO4MEXqGTuaZCfQUbiutJIg+B7T1/KMU3PF 6rBnqPrWvqQqjnxHkh9aiSlgqyAplzksHtdEtxKxJ0CTGgaDnPlZiXevVV5jRQq8MENs 28ZHYeJ39b1vXGOiBhC1sYdZonkUQK6LztNo0= Received: by 10.210.78.16 with SMTP id a16mr11921909ebb.173.1220536376528; Thu, 04 Sep 2008 06:52:56 -0700 (PDT) Received: from alpha.local ( [83.144.140.92]) by mx.google.com with ESMTPS id j8sm21284711gvb.1.2008.09.04.06.52.55 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 04 Sep 2008 06:52:55 -0700 (PDT) Received: by alpha.local (Postfix, from userid 1001) id C0F2010064; Thu, 4 Sep 2008 14:52:00 +0100 (WEST) Date: Thu, 4 Sep 2008 14:52:00 +0100 From: Rui Paulo To: Jeremie Le Hen Message-ID: <20080904135200.GC31289@alpha.local> References: <20080904124653.GK72107@obiwan.tataz.chchile.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080904124653.GK72107@obiwan.tataz.chchile.org> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: Rui Paulo Cc: freebsd-hackers@FreeBSD.org Subject: Re: Creation of the NO_SSP build knob X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Sep 2008 13:52:58 -0000 On Thu, Sep 04, 2008 at 02:46:53PM +0200, Jeremie Le Hen wrote: > Hello, > > There is currently a knob to enable/disable SSP: WITH_SSP or > WITHOUT_SSP. WITH_SSP is the default on -CURRENT, so no one had to put > WITH_SSP= in src.conf(5). This has hidden the following bug so far: > > When buildworld is run with WITH_SSP= on command-line or in src.conf(5), > it fails immediately with the following message, because the toolchain > is built with WITHOUT_SSP: > > % "/usr/src/share/mk/bsd.own.mk", line 365: WITH_SSP and WITHOUT_SSP can't both be set. > > My leaning is to create an additional knob NO_SSP, much like > NO_CPU_CFLAGS, that could be set internally. However I'm not sure it > complies with the src.conf(5) policy. Any objection to the patch below? We already have something like that. WITHOUT_SENDMAIL= is expanded to MK_SENDMAIL=no. You may want to do the same for SSP and keep the convention of the variable names.