From nobody Thu Jun 11 21:05:35 2026 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gbwCw3yWkz6gcdl for ; Thu, 11 Jun 2026 21:05:48 +0000 (UTC) (envelope-from acespinoza2005@gmail.com) Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gbwCv6YNYz3mmn for ; Thu, 11 Jun 2026 21:05:47 +0000 (UTC) (envelope-from acespinoza2005@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of acespinoza2005@gmail.com designates 209.85.161.52 as permitted sender) smtp.mailfrom=acespinoza2005@gmail.com Received: by mail-oo1-f52.google.com with SMTP id 006d021491bc7-69e59978deeso166772eaf.0 for ; Thu, 11 Jun 2026 14:05:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781211947; x=1781816747; h=to:subject:message-id:date:from:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fu2WEOdba5tl7ZPtPF4Pvls9lGClAPiLYtE+W2t+dG4=; b=ieV/eu5GsUCFhIljPkQZuJgEJPguDypg74GGQHaKRxhqsD4xzgd0Ecj8ai1Vscusel svHB/QlWdx8cmFjfz5i2GFt/fcuMPebTCuCtVpo1Ed+PHLsw995YcHaRiqTBcn9m1aD7 zvTUmtExbijEUNCF2KFyU2Q/6vA5+XdNWRV376GMm55M3qtWEMYgAw1AcXsVaMd/mHhW RDiPhiV9yX8aXVjQ5hBGdvQTx2m43yAhSblmOazQH7jUsCMfDo5B5iwUv2J5lNPfEVLU gRc6bUZUH0737SugIsw9ES7j4yuMzf5HIERhBKgroaTkwC2Gg2OWh9wsFP84fje1XueR 7BEQ== X-Gm-Message-State: AOJu0Yw54cvgLBNZmgCgFokg/12d4N46hcZLvnGIY6WtLbwU/4bCA9aF zfbhJDRneI0HyxP5a0SZ8iwgPkqvv2nIqP1VXGnn0y4dmpBq7nFp3CRh0Yrc0ShH X-Gm-Gg: Acq92OEMum/xYgw8c8TXfJkyKi3mRJCPYSUGwTOxlTjZ9BJZ88Au+lH/t8wRy/Uzpue kvya9UyZrx/jagkROODfAyUcVvxaWob8YldwVOJtsJxXfTV4FoulpW+Foo3hiyRBpqhr6jkQ2Ug OSJWwfpqNkckQ2u6L3YWosGHzNYBSP7Oymwzgv35YgU5dP850sD4XsDTHwrIzC10hru+qQ3ZLxv siMVcCYO0N/ynXYzJbMB+BSG2I01RgA8QzD1t8G9t2dpAIeZZHi8Rt/JTL2IZfEf4nWMt6TIlLn SkLuaTg9qzoAPWBe9kzCPg4PCVXcOm2Isl11hrs06XlDhEjlOrz2j0FE5fBXihM2gz/kCwCxWiC l5VDr+w+2FdLpRmErZNq93wa3AVwxlqrb7l95rkMCcLpVKkhtk7rGpGypziFpLkwNaQ0Fn5xOhK 9KQ9LJKBIwx/crbva/BPbVMBAF5jyyzjZUTZeOPRbOc710NwvxULTwSI7lnp/YEpdres4uTw== X-Received: by 2002:a05:6820:1907:b0:69e:ba66:4e11 with SMTP id 006d021491bc7-69ecb08102amr3115186eaf.56.1781211946635; Thu, 11 Jun 2026 14:05:46 -0700 (PDT) Received: from mail-oo1-f54.google.com (mail-oo1-f54.google.com. [209.85.161.54]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-69ed8162364sm521088eaf.0.2026.06.11.14.05.46 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2026 14:05:46 -0700 (PDT) Received: by mail-oo1-f54.google.com with SMTP id 006d021491bc7-69e59978deeso166767eaf.0 for ; Thu, 11 Jun 2026 14:05:46 -0700 (PDT) X-Received: by 2002:a05:6820:818e:b0:69e:57a1:892a with SMTP id 006d021491bc7-69ecb07d82bmr3266970eaf.55.1781211945952; Thu, 11 Jun 2026 14:05:45 -0700 (PDT) List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 From: Aaron Espinoza Date: Thu, 11 Jun 2026 16:05:35 -0500 X-Gmail-Original-Message-ID: X-Gm-Features: AVVi8Cd6ljYuoXigMBGU74EnrDTZvBDjaP2ekP5pyL_ozR-kuKoj7IpI6K-8Vsw Message-ID: Subject: if_bridge: unused 'disable' parameter in bridge_stop() To: freebsd-net@freebsd.org Content-Type: multipart/alternative; boundary="0000000000004eeec3065400b96b" X-Spamd-Result: default: False [-2.23 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.89)[-0.887]; NEURAL_HAM_MEDIUM(-0.34)[-0.342]; FORGED_SENDER(0.30)[acesp25@freebsd.org,acespinoza2005@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; RWL_MAILSPIKE_GOOD(-0.10)[209.85.161.52:from]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; RCPT_COUNT_ONE(0.00)[1]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; MISSING_XM_UA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_DN_NONE(0.00)[]; FROM_NEQ_ENVFROM(0.00)[acesp25@freebsd.org,acespinoza2005@gmail.com]; FROM_HAS_DN(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; R_DKIM_NA(0.00)[]; MLMMJ_DEST(0.00)[freebsd-net@freebsd.org]; TO_DOM_EQ_FROM_DOM(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.161.52:from,209.85.161.54:received] X-Spamd-Bar: -- X-Rspamd-Queue-Id: 4gbwCv6YNYz3mmn --0000000000004eeec3065400b96b Content-Type: text/plain; charset="UTF-8" Hello, I was tracing the if_bridge driver on the current main branch and noticed that the bridge_stop method takes in an 'int disable' parameter that doesn't seem to be used in the function itself. Currently, there are two calls to bridge_stop() in the driver: 1. In bridge_clone_destroy() - Line 940 2. In bridge_ioctl() - Line 1073 In both of these calls, the disable parameter is hard-coded to 1. There doesn't seem to be any case where 0 is used for the parameter. Since the ifnet structure doesn't require a stop function, I assume this is purely for the bridge itself. Is this parameter still relevant/needed in the driver architecture? If not, I'd be happy to make a small pr to update this. I'm still finding my footing around the FreeBSD network stack so please let me know if this parameter has a purpose I overlooked. Best, Aaron --0000000000004eeec3065400b96b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

I was tracing the if_= bridge driver on the current main branch and noticed that the bridge_stop m= ethod takes in an 'int disable' parameter=C2=A0that doesn't see= m to be used in the function itself.

Currently, th= ere are two calls to bridge_stop() in the driver:=C2=A0
1. In bri= dge_clone_destroy() - Line 940
2. In bridge_ioctl() - Line 1073
In both of these calls, the disable parameter is hard-coded to 1.<= /div>
There doesn't seem to be any case where 0 is used for the par= ameter.

Since=C2=A0the ifnet structure doesn't= require a stop function, I assume this is purely=C2=A0for the bridge itsel= f.

Is this parameter still relevant/needed in the = driver architecture? If not, I'd be happy to make a small pr to update = this.

I'm still finding my footing around the = FreeBSD network stack so please let me know if this parameter has a purpose= I overlooked.

Best,
Aaron





--0000000000004eeec3065400b96b--