From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Jan 31 09:10:21 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0A6F116A420 for ; Tue, 31 Jan 2006 09:10:21 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8BFE443D76 for ; Tue, 31 Jan 2006 09:10:05 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k0V9A54S039364 for ; Tue, 31 Jan 2006 09:10:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k0V9A5cU039363; Tue, 31 Jan 2006 09:10:05 GMT (envelope-from gnats) Resent-Date: Tue, 31 Jan 2006 09:10:05 GMT Resent-Message-Id: <200601310910.k0V9A5cU039363@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Victor Snezhko Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1AB0916A420 for ; Tue, 31 Jan 2006 09:06:12 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id C858C43D7F for ; Tue, 31 Jan 2006 09:06:11 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k0V96Bwq037254 for ; Tue, 31 Jan 2006 09:06:11 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id k0V96BrS037253; Tue, 31 Jan 2006 09:06:11 GMT (envelope-from nobody) Message-Id: <200601310906.k0V96BrS037253@www.freebsd.org> Date: Tue, 31 Jan 2006 09:06:11 GMT From: Victor Snezhko To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Cc: Subject: ports/92594: [patch] postgresql81-server startup script can't set default database encoding in initdb X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jan 2006 09:10:21 -0000 >Number: 92594 >Category: ports >Synopsis: [patch] postgresql81-server startup script can't set default database encoding in initdb >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Jan 31 09:10:02 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Victor Snezhko >Release: 6.0-RELEASE >Organization: IndorSoft Ltd. >Environment: FreeBSD 6.0-RELEASE-p4 FreeBSD 6.0-RELEASE-p4 #2: Sat Jan 28 10:06:27 NOVT 2006 root@:/usr/obj/usr/src/sys/VVS i386 >Description: There is no clean way to supply -E (default database encoding) option to initdb. For now it's only possible to modify a startup script. >How-To-Repeat: install postgresql81-server >Fix: I suggest adding an option 'postgresql_initdb_encoding'. Here is the patch against postgresql81-server: --- 010.pgsql.sh.orig Tue Jan 31 21:02:49 2006 +++ 010.pgsql.sh Tue Jan 31 21:22:55 2006 @@ -12,6 +12,7 @@ # # optional # postgresql_data="/usr/local/pgsql/data" # postgresql_flags="-w -s -m fast" +# postgresql_initdb_encoding="UTF8" # # This scripts takes one of the following commands: # @@ -28,6 +29,7 @@ # set defaults postgresql_enable=${postgresql_enable:-"NO"} postgresql_flags=${postgresql_flags:-"-w -s -m fast"} +postgresql_initdb_encoding=${postgresql_initdb_encoding:-"SQL_ASCII"} postgresql_user=pgsql eval postgresql_data=${postgresql_data:-"~${postgresql_user}/data"} postgresql_class=${postgresql_class:-"default"} @@ -53,7 +55,7 @@ postgresql_initdb() { - su -l -c ${postgresql_class} ${postgresql_user} -c "exec ${prefix}/bin/initdb -D ${postgresql_data}" + su -l -c ${postgresql_class} ${postgresql_user} -c "exec ${prefix}/bin/initdb -D ${postgresql_data} -E ${postgresql_initdb_encoding}" } run_rc_command "$1" >Release-Note: >Audit-Trail: >Unformatted: