From owner-freebsd-ports  Thu Feb 21  9:20:15 2002
Delivered-To: freebsd-ports@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id BABA537B41E
	for <freebsd-ports@hub.freebsd.org>; Thu, 21 Feb 2002 09:20:01 -0800 (PST)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g1LHK1G76905;
	Thu, 21 Feb 2002 09:20:01 -0800 (PST)
	(envelope-from gnats)
Received: from dan.emsphone.com (dan.emsphone.com [199.67.51.101])
	by hub.freebsd.org (Postfix) with ESMTP id 6F46D37B405
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 21 Feb 2002 09:12:27 -0800 (PST)
Received: (from dan@localhost)
	by dan.emsphone.com (8.11.6/8.11.6) id g1LHCQt63424;
	Thu, 21 Feb 2002 11:12:26 -0600 (CST)
	(envelope-from dan)
Message-Id: <200202211712.g1LHCQt63424@dan.emsphone.com>
Date: Thu, 21 Feb 2002 11:12:26 -0600 (CST)
From: Dan Nelson <dnelson@allantgroup.com>
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.113
Subject: ports/35184: [patch] ruby-optparse use of uninitialized variable in Makefile
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ports.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-ports>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-ports>
X-Loop: FreeBSD.org


>Number:         35184
>Category:       ports
>Synopsis:       [patch] ruby-optparse use of uninitialized variable in Makefile
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Feb 21 09:20:01 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     Dan Nelson
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
The Allant Group
>Environment:
System: FreeBSD dan.emsphone.com 5.0-CURRENT FreeBSD 5.0-CURRENT #131: Tue Feb 19 11:33:38 CST 2002 zsh@dan.emsphone.com:/usr/src/sys/i386/compile/DANSMP i386


	
>Description:

The do-install target of the port Makefile uses ${f} before it is set. 
This makes the install fail if the user has an environment variable 'f'
set.

	
>How-To-Repeat:

export f=hello
make install

	
>Fix:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/devel/ruby-optparse/Makefile,v
retrieving revision 1.19
diff -u -r1.19 Makefile
--- Makefile	13 Dec 2001 05:02:24 -0000	1.19
+++ Makefile	21 Feb 2002 16:48:03 -0000
@@ -36,7 +36,7 @@
 do-install:
 	${MKDIR} ${RUBY_SITELIBDIR}/${PORTNAME}
 	${INSTALL_DATA} ${WRKSRC}/optparse.rb ${RUBY_SITELIBDIR}/
-	${INSTALL_DATA} ${WRKSRC}/optparse/*.rb${f} ${RUBY_SITELIBDIR}/${PORTNAME}/
+	${INSTALL_DATA} ${WRKSRC}/optparse/*.rb ${RUBY_SITELIBDIR}/${PORTNAME}/
 .if !defined(NOPORTDOCS)
 	${MKDIR} ${RUBY_EXAMPLESDIR}/${PORTNAME}/ja
 	${MKDIR} ${RUBY_DOCDIR}/${PORTNAME}/ja

	


>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message