From owner-freebsd-current@FreeBSD.ORG Fri Nov 18 10:40:30 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A5CC61065674; Fri, 18 Nov 2011 10:40:30 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id B2DFD8FC12; Fri, 18 Nov 2011 10:40:29 +0000 (UTC) Received: by wwg14 with SMTP id 14so4722813wwg.31 for ; Fri, 18 Nov 2011 02:40:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=PfInaVEPJ86O8EasK7bCihcdMa21xqCYWdz1QY3vQCU=; b=LQv0G0YgI3/8CQuY6FYcgCCd9mUDs3ystdgrlrCbPS4RdBvyvsDUWYO8pYF1NzlItr tXF2gyEaNUvJEuTw93Q4ua0iASHRTayfVQfPoOAFz1sKk4vG5AgNIeAdQlsSPHTvtHxa Xci/d/5gfevQ/BiBIQXIjbXI8lsI1c1iDf/HY= MIME-Version: 1.0 Received: by 10.216.166.212 with SMTP id g62mr420481wel.29.1321612828577; Fri, 18 Nov 2011 02:40:28 -0800 (PST) Sender: asmrookie@gmail.com Received: by 10.216.85.8 with HTTP; Fri, 18 Nov 2011 02:40:28 -0800 (PST) In-Reply-To: <20111116084542.GY50300@deviant.kiev.zoral.com.ua> References: <4EB4095D.3030303@rice.edu> <20111104160339.GM50300@deviant.kiev.zoral.com.ua> <20111105141306.GW50300@deviant.kiev.zoral.com.ua> <20111105151530.GX50300@deviant.kiev.zoral.com.ua> <4EB595FA.4020500@rice.edu> <20111106124331.GP50300@deviant.kiev.zoral.com.ua> <4EB81942.70501@rice.edu> <20111107193516.GA50300@deviant.kiev.zoral.com.ua> <20111116084542.GY50300@deviant.kiev.zoral.com.ua> Date: Fri, 18 Nov 2011 11:40:28 +0100 X-Google-Sender-Auth: mH73E1qmpvLLZ85PhP0IZn3liQs Message-ID: From: Attilio Rao To: Kostik Belousov Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: mdf@freebsd.org, "K. Macy" , Alan Cox , Andriy Gapon , freebsd-current@freebsd.org, Benjamin Kaduk , Penta Upa Subject: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2011 10:40:30 -0000 2011/11/16 Kostik Belousov : > On Tue, Nov 15, 2011 at 07:15:01PM +0100, Attilio Rao wrote: >> 2011/11/7 Kostik Belousov : >> > On Mon, Nov 07, 2011 at 11:45:38AM -0600, Alan Cox wrote: >> >> Ok. =C2=A0I'll offer one final suggestion. =C2=A0Please consider an a= lternative >> >> suffix to "func". =C2=A0Perhaps, "kbi" or "KBI". =C2=A0In other words= , something >> >> that hints at the function's reason for existing. >> > >> > Sure. Below is the extraction of only vm_page_lock() bits, together >> > with the suggested rename. When Attilio provides the promised simplifi= cation >> > of the mutex KPI, this can be reduced. >> >> My tentative patch is here: >> http://www.freebsd.org/~attilio/mutexfileline.patch >> >> I need to make more compile testing later, but it already compiles >> GENERIC + modules fine on HEAD. >> >> The patch provides a common entrypoint, option independent, for both >> fast case and debug/compat case. >> Additively, it almost entirely fixes the standard violation of the >> reserved namespace, as you described (the notable exception being the >> macro used in the fast path, that I want to fix as well, but in a >> separate commit). >> >> Now the file/line couplet can be passed to the "_" suffix variant of >> the flag functions. > Yes, this is exactly KPI that I would use when available for the > vm_page_lock() patch. > >> >> eadler@ reviewed the mutex.h comment. >> >> Please let me know what you think about it, as long as we agree on the >> patch I'll commit it. > But I also agree with John that imposing large churn due to the eliminati= on > of the '__' prefix is too late now. At least it will make the change > non-MFCable. Besides, we already lived with the names for 10+ years. > > I will be happy to have the part of the patch that exports the mtx_XXX_(m= tx, > file, line) defines which can be used without taking care of LOCK_DEBUG > or MUTEX_NOINLINE in the consumer code. Ok, this patch should just add the compat stub: http://www.freebsd.org/~attilio/mutexfileline2.patch I'll make more test-compiling later in the day, if you agree on it I will commit the patch tomorrow. Attilio --=20 Peace can only be achieved by understanding - A. Einstein