From owner-cvs-all Sat Jan 23 16:26:31 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id QAA09086 for cvs-all-outgoing; Sat, 23 Jan 1999 16:26:31 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.26.10.9]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id QAA09079; Sat, 23 Jan 1999 16:26:24 -0800 (PST) (envelope-from bde@godzilla.zeta.org.au) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.7/8.8.7) id LAA24168; Sun, 24 Jan 1999 11:26:12 +1100 Date: Sun, 24 Jan 1999 11:26:12 +1100 From: Bruce Evans Message-Id: <199901240026.LAA24168@godzilla.zeta.org.au> To: eivind@FreeBSD.ORG, jdp@polstra.com Subject: Re: cvs commit: src/usr.bin/xlint/xlint xlint.c Cc: committers@FreeBSD.ORG Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk >> usr.bin/xlint/xlint xlint.c >> Log: >> I may have forgotten to upgrade this value, but that will never happen >> again. (Fully clone the value of __FreeBSD__ from the compiler.) >> >> Revision Changes Path >> 1.6 +8 -6 src/usr.bin/xlint/xlint/xlint.c > >I'm glad you put in this automatic solution. But please get >rid of your local STRINGIZE(x) and STRINGIZEINT(x) macros, and >use the FreeBSD-standard __XSTRING(x) instead. It is defined Also, use the FreeBSD-standard __CONCAT() macro if you don't want to break xlint's K&R support some more :-). Lint still doesn't define __FreeBSD_cc_version or several other magic defines that may be important (e.g., __GNUC__, __ELF__). It kills the standard defines by passing the -undef option to cpp and then adds back a couple. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message