From owner-svn-ports-all@freebsd.org Mon Nov 12 18:34:25 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AB87C110DE96; Mon, 12 Nov 2018 18:34:25 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 356467CB1D; Mon, 12 Nov 2018 18:34:25 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from atuin.in.mat.cc (unknown [IPv6:2a01:678:42:ffff:3e15:c2ff:fec4:452e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 506691ABC0; Mon, 12 Nov 2018 18:34:24 +0000 (UTC) (envelope-from mat@FreeBSD.org) Date: Mon, 12 Nov 2018 19:34:23 +0100 From: Mathieu Arnold To: Max Brazhnikov Cc: Jan Beich , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, henry.hu.sh@gmail.com Subject: Re: svn commit: r484686 - head/net-im/telegram-desktop Message-ID: <20181112183423.xmp67tjjghceot75@atuin.in.mat.cc> References: <201811111145.wABBjKcf027649@repo.freebsd.org> <5zx3-zver-wny@FreeBSD.org> <4618826.YNO7O01DYZ@mercury.ph.man.ac.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2qtltp4qbttzu2l4" Content-Disposition: inline In-Reply-To: <4618826.YNO7O01DYZ@mercury.ph.man.ac.uk> User-Agent: NeoMutt/20180716 X-Rspamd-Queue-Id: 356467CB1D X-Spamd-Result: default: False [-108.92 / 200.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ALLOW_DOMAIN_WHITELIST(-100.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.00)[FreeBSD.org]; R_SPF_SOFTFAIL(0.00)[~all]; RCPT_COUNT_FIVE(0.00)[6]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MX_GOOD(-0.01)[cached: mx1.FreeBSD.org]; NEURAL_HAM_SHORT(-1.00)[-0.999,0]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; IP_SCORE(-3.71)[ip: (-9.72), ipnet: 96.47.64.0/20(-4.82), asn: 11403(-3.90), country: US(-0.09)]; ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Nov 2018 18:34:26 -0000 --2qtltp4qbttzu2l4 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 11, 2018 at 11:59:48AM +0000, Max Brazhnikov wrote: > On =D0=B2=D0=BE=D1=81=D0=BA=D1=80=D0=B5=D1=81=D0=B5=D0=BD=D1=8C=D0=B5, 11= =D0=BD=D0=BE=D1=8F=D0=B1=D1=80=D1=8F 2018 =D0=B3. 11:49:16 UTC Jan Beich w= rote: > > Max Brazhnikov writes: > > > @@ -82,6 +82,7 @@ post-patch: > > > ${FILESDIR}/gyp-patches | \ > > > ${PATCH} -z .bak -s) > > > =09 > > > @${ECHO} "#define FREEBSD_QT_PLUGINDIR \"${QT_PLUGINDIR}\"" > > > > ${WRKSRC}/Telegram/SourceFiles/FREEBSD_QT_PLUGINDIR.h>=20 > > > + ${SED} -i -e "/Icon=3D/s|telegram|${PORTNAME}|" > > > ${WRKSRC}/lib/xdg/telegramdesktop.desktop > > Why ${SED} -i instead of ${REINPLACE_CMD}? >=20 > For sake of consistency with the rest of the file. I leave it to maintain= er. The reason we have committers and not a simple script that commits every patch that applies in is so that people who know better (the committers, you, Jan, me) fix submissions from maintainers to match our policies and way of doing things. Now, the Makefile is consistenly bad, that is for sure. --=20 Mathieu Arnold --2qtltp4qbttzu2l4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlvpx69fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkj2ag//a08ODOKL9VtoblJurGkNTvcFT/V+KH1046eqcyge9t+jk7klHwMJoVM7 lPz9Tshgiq+FO538a0pNERqqQNyIsNETsjdru7FFNuJyh7fvZ46aU0j0oEKlmE8q rGaSm5S6lyMeAOYnnP5WWHJ0QBuCW/DkwF5lxTB7/dxMwJY3PjvMPrijCrwdKA67 5RI7ydhmDMfd2X1wxht4PnDNYT/sxDYQ8wLrfPvj6D+48cXiqlVyOCB8aYhX/hQP 0kmZtDJ44nG8QSwBSyOQCCLe5cCPFN6afFulM722rgTvx+pVo7gRgiUxK3KaTKqg dci8FpOJxOwIDtlKVGfg6j3KGMf7adCsVNfVILWPClu9oAOs9wFmBlteFU2wqTGS 4FjJmICrKsQsJtL1/qBVWqMzbRdV0EPPtfn5w5nzueDo5SUHkw+GzAAGR0CqlMYo 62tSYoQ5z6NdlIUOjNWdf9AAt7n1DiNlOK16y+F/NdKAkij9eIPwWaqVONU9IHEY eG4lCYIyvAf4KiAk3O6x/P7YCOPfWVCKOFeWaVqgKSCkMXC0kF0VI+AZmwgpwRSU QQyKwSCOeem9VrBzRnJgf7Ldeg3TUDauzxx+U3qOTB48TRBfVVSpWdEGqLXg5gEo opKfwwTXglOe647fXX2SzQEbpXMhL2Z84H7902clkOhurmeY1jM= =IvLE -----END PGP SIGNATURE----- --2qtltp4qbttzu2l4--