Date: Tue, 24 Dec 2019 09:41:31 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Luca Pizzamiglio <pizzamig@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r520731 - in head/editors: . vscode vscode/files Message-ID: <20191224084131.k34frbhv6lcygwnp@ivaldir.net> In-Reply-To: <201912231723.xBNHNMfI019819@repo.freebsd.org> References: <201912231723.xBNHNMfI019819@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--4tgw5amptrowfry2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 23, 2019 at 05:23:22PM +0000, Luca Pizzamiglio wrote: > Author: pizzamig > Date: Mon Dec 23 17:23:22 2019 > New Revision: 520731 > URL: https://svnweb.freebsd.org/changeset/ports/520731 >=20 > Log: > editors/vscode: Add new port > =20 > Add vscode to the portstree. the popular editor developed by Microsoft = and > based on Electron. > Many thanks to the maintainer Hiroki for his very appreciated work on i= t. >=20 > Added: > head/editors/vscode/ > head/editors/vscode/Makefile (contents, props changed) > head/editors/vscode/distinfo (contents, props changed) > head/editors/vscode/files/ > head/editors/vscode/files/extra-patch-build_gulpfile.extensions.js (c= ontents, props changed) > head/editors/vscode/files/package.json-build (contents, props changed) > head/editors/vscode/files/package.json-package (contents, props chang= ed) > head/editors/vscode/files/package.json-remote-build (contents, props = changed) > head/editors/vscode/files/package.json-remote-package (contents, prop= s changed) > head/editors/vscode/files/patch-build_lib_snapshotLoader.ts (contents= , props changed) > head/editors/vscode/files/patch-build_npm_postinstall.js (contents, p= rops changed) > head/editors/vscode/files/patch-extensions_emmet_src_test_testUtils.ts = (contents, props changed) > head/editors/vscode/files/patch-extensions_vscode-api-tests_src_utils.t= s (contents, props changed) > head/editors/vscode/files/patch-extensions_vscode-test-resolver_scripts= _terminateProcess.sh (contents, props changed) > head/editors/vscode/files/patch-extensions_vscode-test-resolver_src_uti= l_processes.ts (contents, props changed) > head/editors/vscode/files/patch-product.json (contents, props changed) > head/editors/vscode/files/patch-resources_linux_bin_code.sh (contents= , props changed) > head/editors/vscode/files/patch-src_bootstrap.js (contents, props cha= nged) > head/editors/vscode/files/patch-src_paths.js (contents, props changed) > head/editors/vscode/files/patch-src_vs_base_common_platform.ts (conte= nts, props changed) > head/editors/vscode/files/patch-src_vs_code_electron-main_app.ts (con= tents, props changed) > head/editors/vscode/files/patch-src_vs_workbench_api_browser_mainThread= Task.ts (contents, props changed) > head/editors/vscode/files/patch-src_vs_workbench_contrib_extensions_bro= wser_extensionEditor.ts (contents, props changed) > head/editors/vscode/files/patch-src_vs_workbench_services_extensions_no= de_proxyResolver.ts (contents, props changed) > head/editors/vscode/files/patch-test_automation_src_code.ts (contents= , props changed) > head/editors/vscode/files/patch-test_smoke_src_main.ts (contents, pro= ps changed) > head/editors/vscode/files/yarnrc-offline-mirror (contents, props chan= ged) > head/editors/vscode/pkg-descr (contents, props changed) > head/editors/vscode/pkg-plist (contents, props changed) > Modified: > head/editors/Makefile >=20 > Modified: head/editors/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/editors/Makefile Mon Dec 23 16:14:51 2019 (r520730) > +++ head/editors/Makefile Mon Dec 23 17:23:22 2019 (r520731) > @@ -248,6 +248,7 @@ > SUBDIR +=3D vim > SUBDIR +=3D vim-console > SUBDIR +=3D vim-tiny > + SUBDIR +=3D vscode > SUBDIR +=3D web-mode > SUBDIR +=3D with-editor > SUBDIR +=3D wordgrinder >=20 > Added: head/editors/vscode/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/editors/vscode/Makefile Mon Dec 23 17:23:22 2019 (r520731) > @@ -0,0 +1,254 @@ > +# $FreeBSD$ > + > +PORTNAME=3D vscode > +DISTVERSION=3D 1.41.0 > +CATEGORIES=3D editors > +MASTER_SITES=3D https://atom.io/download/electron/v${ELECTRON_VER}/:elec= tron_headers \ > + https://github.com/electron/electron/releases/download/v${ELECTRON_VER= }/:electron_linux \ > + https://nodejs.org/dist/v${NODE_VER}/:node_headers \ > + https://registry.yarnpkg.com/vscode-ripgrep/-/:vscode_ripgrep \ > + https://github.com/tagattie/FreeBSD-VSCode/releases/download/${DISTVER= SION}/:yarn_cache > +DISTFILES=3D node-v${ELECTRON_VER}-headers${EXTRACT_SUFX}:electron_heade= rs \ > + electron-v${ELECTRON_VER}-linux-x64.zip:electron_linux \ > + ffmpeg-v${ELECTRON_VER}-linux-x64.zip:electron_linux \ > + node-v${NODE_VER}-headers${EXTRACT_SUFX}:node_headers \ > + vscode-ripgrep-${VSCODE_RIPGREP_VER}.tgz:vscode_ripgrep > +DIST_SUBDIR=3D ${PORTNAME} > +EXTRACT_ONLY=3D ${DISTNAME}${EXTRACT_SUFX} > + > +MAINTAINER=3D tagattie@yandex.com > +COMMENT=3D Visual Studio Code - Open Source ("Code - OSS") > + > +LICENSE=3D MIT > +LICENSE_FILE=3D ${WRKSRC}/LICENSE.txt > + > +ONLY_FOR_ARCHS=3D amd64 > + > +BUILD_DEPENDS=3D electron:devel/electron6 \ > + rg:textproc/ripgrep \ > + npm:www/npm-node10 \ > + yarn:www/yarn-node10 > +LIB_DEPENDS=3D libatk-bridge-2.0.so:accessibility/at-spi2-atk \ > + libsnappy.so:archivers/snappy \ > + libasound.so:audio/alsa-lib \ > + libFLAC.so:audio/flac \ > + libopus.so:audio/opus \ > + libdbus-1.so:devel/dbus \ > + libinotify.so:devel/libinotify \ > + libnotify.so:devel/libnotify \ > + libpci.so:devel/libpci \ > + libnspr4.so:devel/nspr \ > + libpcre2-8.so:devel/pcre2 \ > + libre2.so:devel/re2 \ > + libdrm.so:graphics/libdrm \ > + libwebp.so:graphics/webp \ > + libavcodec.so:multimedia/ffmpeg \ > + libvpx.so:multimedia/libvpx \ > + libopenh264.so:multimedia/openh264 \ > + libcups.so:print/cups \ > + libfreetype.so:print/freetype2 \ > + libharfbuzz.so:print/harfbuzz \ > + libsecret-1.so:security/libsecret \ > + libnss3.so:security/nss \ > + libexpat.so:textproc/expat2 \ > + libfontconfig.so:x11-fonts/fontconfig > +RUN_DEPENDS=3D ${LOCALBASE}/lib/alsa-lib/libasound_module_pcm_oss.so:aud= io/alsa-plugins \ > + xdg-open:devel/xdg-utils \ > + bash:shells/bash > +TEST_DEPENDS=3D electron:devel/electron6 \ > + bash:shells/bash > + > +USES=3D desktop-file-utils gl gmake gnome jpeg pkgconfig \ > + python:2.7,build shebangfix xorg > + > +USE_GITHUB=3D yes > +GH_ACCOUNT=3D microsoft > + > +SOURCE_COMMIT_HASH=3D 9579eda04fdb3a9bba2750f15193e5fafe16b959 > + > +BINARY_ALIAS=3D python=3D${PYTHON_CMD} > + > +USE_XORG=3D x11 xcb xcomposite xcursor xdamage xext xfixes xi xkbfile \ > + xrandr xrender xscrnsaver xtst > +USE_GL=3D gl glesv2 > +USE_GNOME=3D atk cairo pango gdkpixbuf2 gtk30 libxml2 libxslt > + > +USE_LDCONFIG=3D ${DATADIR} > + > +ELECTRON_VER=3D 6.1.6 # keep in sync with devel/electron6 > +NODE_VER=3D 12.4.0 > +VSCODE_RIPGREP_VER=3D 1.5.7 > + > +SHEBANG_FILES=3D extensions/vscode-test-resolver/scripts/terminateProces= s.sh \ > + resources/linux/bin/code.sh \ > + scripts/test.sh > + > +DATADIR=3D ${PREFIX}/share/code-oss > +TMPDIR=3D ${WRKDIR} > + > +MAKE_ENV+=3D BUILD_SOURCEVERSION=3D${SOURCE_COMMIT_HASH} \ > + PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=3D1 \ > + XDG_CACHE_HOME=3D${WRKDIR}/.cache > + > +OPTIONS_DEFINE=3D POUDRIERE > +POUDRIERE_DESC=3D Support build with poudriere (KEEP THIS ON) > +OPTIONS_DEFAULT=3D POUDRIERE I don't think you should use a POUDRIERE option, you should instead use the PACKAGE_BUILDING knob, which every package builders are supposed to export. This makes is not limited to poudriere, should achieve what you do expect a= nd prevent showing a "weird" option to end users Best regards, Bapt --4tgw5amptrowfry2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAl4BzzsACgkQY4mL3PG3 Plo5wQ/+KLo7a6Vq+oU4VMujd2q47gnK+N0lzypMwQV6VBvhyL/CHvdbe9wZxb0T VWjvj4Sf1ZMcv5goOmUzWPcWpqFxuv0LQBu4r45I9VLkvTxWsp0cSV8w3EwVEakO qbka3ahfvfMn27gVD26cFikD+pryPJr9o2QT6ZiMrahS9Rlb/3Q+QZK+IxmAn91D 2XzKmyDopOcQAGBwvZQ+u7dA0x72DM9iT2b5HIsRJupQ9DRjPCCmiMhpuKdVhyor SoBJsERZoK8UY9qgaZdrHzNuZLH8s7nZNsA32l5FtZGSf/I+FHrowcwvxjH4tJUj BGrP06BcpWtlltVBvPUcg9dlhNwqtj/ho23UPkndNgl7vTKVVLrVezpc1bSButR+ gVwjMKz7URUPmL952azbO9vuhENJZZJRYW1nFdk9aeyRL467xRKaSAnPELKceuil 209aHPpD0OdrETD5SCrhJpSXpy+DJ2BxUPizrKtYktJeCdCErWEi5i9KvBsGhmNQ R3z6j4ZgEPsLPWGJVt+52H6UCpYCPps70jL6mtAypd1id+bwti3vcsZBbXwTRChO jDrZhM57k9t4Xi696lahae84uUS7AGwfLkrlb/qX2SHctytx6Q9Kcrk+TBi7zXxZ 31yYc1EzW96lkLtn41RSYo9v8UvFEOhKEOI0MnZcu/OdT80LCTg= =xJmQ -----END PGP SIGNATURE----- --4tgw5amptrowfry2--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191224084131.k34frbhv6lcygwnp>