Date: Thu, 27 Feb 2025 00:32:22 +0000 (UTC) From: "Bjoern A. Zeeb" <bz@freebsd.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: Michael Tuexen <tuexen@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 0e58542fd246 - main - tcp: remove unused field from struct tcpcb Message-ID: <p572qp23-32pn-1soo-s9q9-04q6o7p0058p@serrofq.bet> In-Reply-To: <Z7-p9krDX93KSnsz@cell.glebi.us> References: <202502252048.51PKm4YX061305@gitrepo.freebsd.org> <r6pqp489-s4oq-0p8q-6r68-3931pss41s33@SerrOFQ.bet> <Z7-p9krDX93KSnsz@cell.glebi.us>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 26 Feb 2025, Gleb Smirnoff wrote:
> On Wed, Feb 26, 2025 at 02:23:46AM +0000, Bjoern A. Zeeb wrote:
> B> > --- a/sys/netinet/tcp_var.h
> B> > +++ b/sys/netinet/tcp_var.h
> B> > @@ -452,7 +452,6 @@ struct tcpcb {
> B> > tcp_seq gput_seq; /* Outbound measurement seq */
> B> > tcp_seq gput_ack; /* Inbound measurement ack */
> B> > int32_t t_stats_gput_prev; /* XXXLAS: Prev gput measurement */
> B> > - uint32_t t_maxpeakrate; /* max peak rate set by user, bytes/s */
> B>
> B> Is the tcpcb no longer KBI relevant these days?
> B> In the old days we'd simply make this a spare and not move all offsets
> B> below around.
>
> In the old days tcpcb was visible to userland, that's why there was
> the spare habit.
Yes, the problem really was with uitilities such as netstat.
But I see you solved that ages ago with struct xtcpcb which has tons
of spares to avoid that problem.
Sorry for the noise.
/bz
--
Bjoern A. Zeeb r15:7
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p572qp23-32pn-1soo-s9q9-04q6o7p0058p>