From nobody Tue Jul 28 10:06:34 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h8WMb1676z6mVs3 for ; Tue, 28 Jul 2026 10:06:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h8WMZ58prz3hLr for ; Tue, 28 Jul 2026 10:06:34 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785233194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BgoMoYsWp8IA5JvZ+G2z3HFZuqxJD1Sn2tLPJcdAZJ0=; b=MgLJZh18mIlguw34soO9XvBx79zFOuGfY58sGKCQjnXDWVx9uaouRF9Vc2pQyJda0LoW2F 6C9jv+DaeMWb9e/XXG4MMqyv2N2+3sp8qbF5yiAnK+e9wSLmEvw0RbwoIEFp2urP1ly5el Ur33kt2QLirgwxn3SLdfw4lXPiIpcWwishHir1NiYhuc4luSF7vtlOXwtOICRZZ+/fFeEr tAGUBy9OavK0vjEmIZy0Xt1NZxh9KRYlZsRLPcxrHeqZedmFhhvVf88ODST8q+M1XLZHUY mnMtqZVhyO6KGgcMJ44ECtgHUZompqyy3WCk5IPvEjU2FG/mMrRWldYII3TUxw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785233194; a=rsa-sha256; cv=none; b=nlLeJ10fN4IRbsnrmIaPwDg+mf4XvQJ4wrhED097aTrtQjHABeEmBMOuPe+lkRHlllM/8y QpSOHJiTQ4ilMeMGDmM2kVfFK8Uge9Eny2V5wneUnsDOurpxRhLvckXiqFetKwi07Hpd9l nD53CQrdIHUm/KMPDZRHSwvxsW7zjVq4cXL5N8zIe/glGO3XHgw10zIiYNXLijVIiwGolA xPffUzBSgFsTssmOd6RLzwfeujmtgS8uk9uJxwdVnEHurMx4EabmNRUU5jiW+QEW5xtwq3 oTwS0dtYat6wtu0aUnNnz4OOLStbMWf8nuY7V3fEHtb9WRcfkkZJwkbh9sZXNA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785233194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BgoMoYsWp8IA5JvZ+G2z3HFZuqxJD1Sn2tLPJcdAZJ0=; b=btGShgcyet4fU+icSwTIEEm+Pd3OLSSa2IykkcF6KEGDUjeWzEZp68AJnSAI+D9GEV2ZG2 0yoHoj9cy6EFEazvt+rx7mmEDG4002pUBWrsyJa20ZSNt2yTae6iGM+SgzE+78G/cbcxIz K6/xSJbfpDjlcOPyxUf1b+hEiXEssNTUo4TMkUkD6bGBVpERgplA2fTq0qiMLrAnvn7I0T FG0/gPO7FK0lRUivJrbo8a752YigYhlSZpAnn5ahq/oqjqyoaBb/k/T7JWSohwtJZ81m/p GCbUpLJvuHXkEhv0YZA3QmgJD/QV3x9JfM5YfoSEPJeMWuYBGYs0AmgDDVzRIg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h8WMZ3khLzbkV for ; Tue, 28 Jul 2026 10:06:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 201ab by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 28 Jul 2026 10:06:34 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Siva Mahadevan From: Alexander Leidinger Subject: git: 6afb2b8e2fa7 - stable/15 - tests/exterr_test: use ATF_REQUIRE_FEATURE to check exterr_strings List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: netchild X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 6afb2b8e2fa7608b9e3e3ec2035319cca00481ce Auto-Submitted: auto-generated Date: Tue, 28 Jul 2026 10:06:34 +0000 Message-Id: <6a687f2a.201ab.5359f62@gitrepo.freebsd.org> The branch stable/15 has been updated by netchild: URL: https://cgit.FreeBSD.org/src/commit/?id=6afb2b8e2fa7608b9e3e3ec2035319cca00481ce commit 6afb2b8e2fa7608b9e3e3ec2035319cca00481ce Author: Siva Mahadevan AuthorDate: 2026-07-22 01:27:11 +0000 Commit: Alexander Leidinger CommitDate: 2026-07-28 10:04:53 +0000 tests/exterr_test: use ATF_REQUIRE_FEATURE to check exterr_strings This keeps the skipped test message consistent with others. Reviewed by: netchild MFC after: 3 days Sponsored by: The FreeBSD Foundation (cherry picked from commit 3e946566c134e039f9c777eaa1232a32e383692c) --- tests/sys/kern/Makefile | 2 ++ tests/sys/kern/exterr_test.c | 5 +++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/sys/kern/Makefile b/tests/sys/kern/Makefile index ab68fbf11a6e..2fc9a9b2aca3 100644 --- a/tests/sys/kern/Makefile +++ b/tests/sys/kern/Makefile @@ -154,6 +154,8 @@ SRCS.subr_physmem_test+= subr_physmem_test.c subr_physmem.c CFLAGS.subr_unit.c+= -Wno-missing-prototypes SRCS.subr_unit_test+= subr_unit.c +CFLAGS.exterr_test+= -I${SRCTOP}/tests + WARNS?= 3 TESTS_SUBDIRS+= acct diff --git a/tests/sys/kern/exterr_test.c b/tests/sys/kern/exterr_test.c index 316b5b66b0e0..bde7654fecfc 100644 --- a/tests/sys/kern/exterr_test.c +++ b/tests/sys/kern/exterr_test.c @@ -34,6 +34,8 @@ #include #include +#include "freebsd_test_suite/macros.h" + /* * Pin the message format by clearing EXTERROR_VERBOSE, which would * otherwise change the output shape. @@ -66,8 +68,7 @@ ATF_TC_BODY(gettext_extended, tc) r = uexterr_gettext(exterr, sizeof(exterr)); ATF_CHECK_EQ(0, r); printf("Extended error: %s\n", exterr); - if (feature_present("exterr_strings") == 0) - atf_tc_skip("kernel built without EXTERR_STRINGS"); + ATF_REQUIRE_FEATURE("exterr_strings"); /* Note: error string may need to be updated due to kernel changes */ ATF_CHECK(strstr(exterr, " is not subset of ") != NULL); }