From owner-svn-src-all@freebsd.org Sat Apr 2 15:58:07 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1D0C3AEB394 for ; Sat, 2 Apr 2016 15:58:07 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D8AFF1ED9 for ; Sat, 2 Apr 2016 15:58:06 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: bb32f4ae-f8eb-11e5-9036-c33267960ba8 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.34.117.227 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.34.117.227]) by outbound2.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA; Sat, 2 Apr 2016 15:58:24 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.14.9) with ESMTP id u32FvtZT014736; Sat, 2 Apr 2016 09:57:55 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1459612675.1091.232.camel@freebsd.org> Subject: Re: svn commit: r297326 - head/sys/nfs From: Ian Lepore To: Julian Elischer , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Sat, 02 Apr 2016 09:57:55 -0600 In-Reply-To: <56FFE7C1.2030904@freebsd.org> References: <201603272316.u2RNGbwi018381@repo.freebsd.org> <56FFE7C1.2030904@freebsd.org> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.16.5 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Apr 2016 15:58:07 -0000 On Sat, 2016-04-02 at 23:39 +0800, Julian Elischer wrote: > On 28/03/2016 7:16 AM, Ian Lepore wrote: > > The theory here is that since we can only have one default > > route, the one > > most likely to be correct for mounting the rootfs is the one > > that was > > delivered along with the rootpath option. > > We can have multiple default routes with weights, and we can have > different default routes in different fibs. > since interfaces can have fibs assigned to them you need to install > the new default if it is useable in the fib of the interface. > This is complicated and most companies that use these features have > special code to do it.. Does any of that apply during bootpc_init(), before rootfs is even mounted? The dhcp server just delivers a router address, and on a multihomed machine you can end up with different addresses coming from different servers (which may be insane as an actual working config, I dunno). In testing what I found was that only the first address delivered ever actually got installed and all subsequent ones resulted in an (ignored) EEXIST error. If what you say applies to the bootp milieu, I'm going to need help making it right. I picked up that PR when I stumbled across it because I'm somewhat familiar with the bootp routines from earlier bugfixes, but the PR really addressed two issues, and on the default route vs. proxy-arp parts of it I'm out of my depth. I suspect in the real world there probably aren't too many configurations that require a gateway to access the nfs server providing a machine's rootfs. It seems fair to assume that if a gateway is required to reach that machine, then the dhcp server that told you about that nfs server will also be the one to give you a useful gateway address for reaching it. I would expect more complex routing stuff to be handled by the rc scripts. -- Ian