From owner-freebsd-bugs@FreeBSD.ORG  Thu Aug 27 16:20:05 2009
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6F049106564A
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 27 Aug 2009 16:20:05 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 5EEC68FC3A
	for <freebsd-bugs@hub.freebsd.org>;
	Thu, 27 Aug 2009 16:20:05 +0000 (UTC)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n7RGK5i0036493
	for <freebsd-bugs@freefall.freebsd.org>; Thu, 27 Aug 2009 16:20:05 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n7RGK5if036492;
	Thu, 27 Aug 2009 16:20:05 GMT (envelope-from gnats)
Date: Thu, 27 Aug 2009 16:20:05 GMT
Message-Id: <200908271620.n7RGK5if036492@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/138004: commit references a PR
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Aug 2009 16:20:05 -0000

The following reply was made to PR kern/138004; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/138004: commit references a PR
Date: Thu, 27 Aug 2009 16:16:05 +0000 (UTC)

 Author: jamie
 Date: Thu Aug 27 16:15:51 2009
 New Revision: 196592
 URL: http://svn.freebsd.org/changeset/base/196592
 
 Log:
   Fix a LOR between allprison_lock and vnode locks by releasing
   allprison_lock before releasing a prison's root vnode.
   
   PR:		kern/138004
   Reviewed by:	kib
   Approved by:	bz (mentor)
   MFC after:	3 days
 
 Modified:
   head/sys/kern/kern_jail.c
 
 Modified: head/sys/kern/kern_jail.c
 ==============================================================================
 --- head/sys/kern/kern_jail.c	Thu Aug 27 16:15:32 2009	(r196591)
 +++ head/sys/kern/kern_jail.c	Thu Aug 27 16:15:51 2009	(r196592)
 @@ -2453,7 +2453,7 @@ prison_deref(struct prison *pr, int flag
  		ppr = pr->pr_parent;
  		for (tpr = ppr; tpr != NULL; tpr = tpr->pr_parent)
  			tpr->pr_childcount--;
 -		sx_downgrade(&allprison_lock);
 +		sx_xunlock(&allprison_lock);
  
  #ifdef VIMAGE
  		if (pr->pr_vnet != ppr->pr_vnet)
 @@ -2479,7 +2479,7 @@ prison_deref(struct prison *pr, int flag
  		/* Removing a prison frees a reference on its parent. */
  		pr = ppr;
  		mtx_lock(&pr->pr_mtx);
 -		flags = PD_DEREF | PD_LIST_SLOCKED;
 +		flags = PD_DEREF;
  	}
  }
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"