From nobody Thu Dec 21 22:46:05 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Sx5BP5PHHz54N6b; Thu, 21 Dec 2023 22:46:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Sx5BP4rhLz4VgL; Thu, 21 Dec 2023 22:46:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1703198765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Qe85FFLrVCHnCF5YaJHCFooZsFodbCtroXLJvhBeaao=; b=bdHc/YNqm2q2qmZwwjUXDRYbWtaVH8ahACi92eff56pELeneWvWJW/Ems6zMJlnZPrX0KX XgGvr6eZJHM/0OIq9S9AMax0gNCwSEL5OV5z+M/guSqF0YrWXkvQw5baKS2tC/+zblSjz+ GDbD3ZB2bUhxTKl0OSlOXvnejT4KJQC9LwViufF41scBAeyId2Vnkl/gUnLms/ACdJtobR tdV51w5RmuApYpVbzcqmvpMa/FH76PEp2XMyL5tZyYl1LFQBYUD5+jvjZZbnn+tBHV92h4 +VQBlazA2PDcXEpGUL1+KdWJmw5m6O2taZvYfiiwNX3Lyd6mg3JPh8BAS3EIug== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1703198765; a=rsa-sha256; cv=none; b=H/yUV9ktTJzGuM341EHMcxccDflqjhx3nAKVKfQMpCBfhU4Pstx4fFk51/vErQWvVqL14Z GKF0h1R0JDUvYezf4TiaH2/HDRxEzuyIlCO7OJg6f3//VlwB7xo2p+71qhhWLeQHBvWUxO o60Uf914BXpfH1Im0+SVcX0hC58HNuJ4jAXhlSclEAaXPv6D2Q9LHdFw4Y4jkJ4qKVuovo 2DKgxk9/ML69MYlVvRSwzhZbLd1YmCQf9WBJ/3H+QlglVPyHgCFHMozrUcMYWn91uVziPE gvIdFESlQnmq9wguFSYU66ncy3tyzVHIboMUoEJoRID495H3T3enb80MBdz78g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1703198765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Qe85FFLrVCHnCF5YaJHCFooZsFodbCtroXLJvhBeaao=; b=DsyJhYrwXVshlyBLt6UH+EwQiS11g9sCmTWDCN2GuCzJ8qwiTvqLMzVjVNRfoyaVa4nteL eTGgKLbEictR5a8eKLvOQlL7TXiYoDEjC29Nq7kCqJ16cdNLoM0GF+3I5JnFgizi+Qu7c/ GXEMI83NB6JiySBpTqth2ifNCZ0toxDWcTWN6wBN95GrvK7u+ZtJTVbfRVHuBNfUDiMx+0 YNn6CkUb5nO2csZDYXhmNIFQVKTXSfJQLeGU95RsCbZ/e71u5TulJ+TVkLWvfP4WkqeoK/ Rvw8DWKFxHbs7LrczWNAIApwmfKaR6uRnwa8kIxrVhLJwYge4bvMZi/PTqQc/A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Sx5BP3p3Wzrm3; Thu, 21 Dec 2023 22:46:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 3BLMk5xe086004; Thu, 21 Dec 2023 22:46:05 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 3BLMk5Oi086001; Thu, 21 Dec 2023 22:46:05 GMT (envelope-from git) Date: Thu, 21 Dec 2023 22:46:05 GMT Message-Id: <202312212246.3BLMk5Oi086001@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dimitry Andric Subject: git: c794d188222a - main - Fix snprintf truncation in telnet List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c794d188222a4d3414233ff9630d47eedc090fbe Auto-Submitted: auto-generated The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=c794d188222a4d3414233ff9630d47eedc090fbe commit c794d188222a4d3414233ff9630d47eedc090fbe Author: Dimitry Andric AuthorDate: 2023-12-21 22:35:17 +0000 Commit: Dimitry Andric CommitDate: 2023-12-21 22:45:52 +0000 Fix snprintf truncation in telnet Building telnet with clang 18 results in the following warning: contrib/telnet/telnet/telnet.c:231:5: error: 'snprintf' will always be truncated; specified size is 10, but format string expands to at least 11 [-Werror,-Wformat-truncation] 231 | snprintf(temp2, sizeof(temp2), "%c%c%c%c....%c%c", IAC, SB, TELOPT_COMPORT, | ^ The temp2 buffer is 10 chars, while the format string also consists of 10 chars. Therefore, snprintf(3) will truncate the last character, 'SE' (end sub negotation) in this case. Bump the buffer to 11 chars to avoid truncation. MFC after: 3 days --- contrib/telnet/telnet/telnet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/telnet/telnet/telnet.c b/contrib/telnet/telnet/telnet.c index a35ea40c4cd8..c936a85c9a23 100644 --- a/contrib/telnet/telnet/telnet.c +++ b/contrib/telnet/telnet/telnet.c @@ -206,7 +206,7 @@ unsigned char ComPortBaudRate[256]; void DoBaudRate(char *arg) { - char *temp, temp2[10]; + char *temp, temp2[11]; int i; uint32_t baudrate;