From owner-svn-src-all@FreeBSD.ORG  Sun Oct 27 07:19:12 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 1894E406;
 Sun, 27 Oct 2013 07:19:12 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 93BDA2AC6;
 Sun, 27 Oct 2013 07:19:10 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.7/8.14.7) with ESMTP id r9R7J9Li045423;
 Sun, 27 Oct 2013 11:19:09 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.7/8.14.7/Submit) id r9R7J96c045422;
 Sun, 27 Oct 2013 11:19:09 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Sun, 27 Oct 2013 11:19:09 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Adrian Chadd <adrian@freebsd.org>
Subject: Re: svn commit: r257184 - in head/sys/dev: mii usb/net xl
Message-ID: <20131027071909.GH52889@FreeBSD.org>
References: <201310261840.r9QIeH89083767@svn.freebsd.org>
 <CAJ-VmonmXgQUOFDw=ZHYXVbsNS54vUwCXt8JiZ=mKENvG85F9Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJ-VmonmXgQUOFDw=ZHYXVbsNS54vUwCXt8JiZ=mKENvG85F9Q@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 27 Oct 2013 07:19:12 -0000

On Sat, Oct 26, 2013 at 06:57:04PM -0700, Adrian Chadd wrote:
A> hm, so none of the modified PHYs nor their consumers will get upset?
A> Eg, if the NIC is down, is touching the PHY registers going to be a
A> problem?

The IFF_UP was always an administrative flag. I believe drivers initialize
all their resources before being set an address with SIOCSIFADDR.

If a driver doesn't, then the previous code still was racy.

Anyway, I am going to handle any fallouts.


-- 
Totus tuus, Glebius.