From owner-freebsd-current@FreeBSD.ORG Fri Dec 26 07:47:26 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 79E5A1065674 for ; Fri, 26 Dec 2008 07:47:26 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85]) by mx1.freebsd.org (Postfix) with ESMTP id 4430C8FC14 for ; Fri, 26 Dec 2008 07:47:26 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1]) by dragon.nuxi.org (8.14.2/8.14.2) with ESMTP id mBQ7RDZw025460 for ; Thu, 25 Dec 2008 23:27:13 -0800 (PST) (envelope-from obrien@dragon.nuxi.org) Received: (from obrien@localhost) by dragon.nuxi.org (8.14.2/8.14.2/Submit) id mBQ7RDk0025459 for freebsd-current@freebsd.org; Thu, 25 Dec 2008 23:27:13 -0800 (PST) (envelope-from obrien) Date: Thu, 25 Dec 2008 23:27:12 -0800 From: "David O'Brien" To: freebsd-current@freebsd.org Message-ID: <20081226072712.GA25406@dragon.NUXI.org> Mail-Followup-To: obrien@freebsd.org, freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Operating-System: FreeBSD 8.0-CURRENT User-Agent: Mutt/1.5.16 (2007-06-09) Subject: Shooting sysinstall/SADE geometry warning in the head X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@freebsd.org List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Dec 2008 07:47:26 -0000 It seems Sysinstall and SADE are ingorant of today's disk geometries. Is there good reason to not make this change? I've been getting the gratitious +----------------------------- Message -----------------------------+ |WARNING: A geometry of 290721/16/63 for ad8 is incorrect. Using | |a more likely geometry. If this geometry is incorrect or you | |are unsure as to whether or not it's correct, please consult | |the Hardware Guide in the Documentation submenu or use the | |(G)eometry command to change it now. | | | |Remember: you need to enter whatever your BIOS thinks the | |geometry is! For IDE, it's what you were told in the BIOS | |setup. For SCSI, it's the translation mode your controller is | |using. Do NOT use a ``physical geometry''. | +-----------------------------------------------------------(100%)--+ | [ OK ] | +---------------------[ Press enter or space ]----------------------+ warning from just about every usage of sysinstall/SADE over the past few years. Index: disks.c =================================================================== --- disks.c (revision 186498) +++ disks.c (working copy) @@ -121,9 +121,6 @@ print_chunks(Disk *d, int u) Total += chunk_info[i]->size; #ifdef PC98 if (d->bios_cyl >= 65536 || d->bios_hd > 256 || d->bios_sect >= 256) { -#else - if (d->bios_cyl > 65536 || d->bios_hd > 256 || d->bios_sect >= 64) { -#endif dialog_clear_norefresh(); msgConfirm("WARNING: A geometry of %lu/%lu/%lu for %s is incorrect. Using\n" "a more likely geometry. If this geometry is incorrect or you\n" @@ -137,6 +134,7 @@ print_chunks(Disk *d, int u) d->bios_cyl, d->bios_hd, d->bios_sect, d->name); Sanitize_Bios_Geom(d); } +#endif attrset(A_NORMAL); mvaddstr(0, 0, "Disk name:\t"); clrtobot(); -- -- David (obrien@FreeBSD.org) Q: Because it reverses the logical flow of conversation. A: Why is top-posting (putting a reply at the top of the message) frowned upon? Let's not play "Jeopardy-style quoting"