Date: Tue, 18 Apr 2000 19:37:42 +0800 From: Adrian Chadd <adrian@freebsd.org> To: freebsd-fs@freebsd.org Subject: FFS and ints Message-ID: <20000418193741.E71428@ewok.creative.net.au>
next in thread | raw e-mail | index | archive | help
Hi,
I just waded through a friends of a friends FFS panic, and it turns uot
that the cg_rotor, cg_irotor and cg_frotor values were all outrageously
wrong. Now, how they got to be wrong is another matter entirely, but
the thing that kept tripping him was that fsck's cg checks were doing
stuff like :
if (cg->cg_frotor < newcg->cg_ndblk)
newcg->cg_frotor = cg->cg_frotor;
else
newcg->cg_frotor = 0;
Now, this makes sense EXCEPT that cg_rotor/frotor/irotor are defined
as int32_ts which mean any weirdnesses that corrupt these values to
negative values will not be picked up in fsck.
So, my question is this: should the cg definition change to change
things that should be unsigned to unsigned, or should fsck change
and we leave the kernel alone?
Adrian
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-fs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20000418193741.E71428>