From owner-freebsd-net@FreeBSD.ORG Wed Nov 10 17:36:07 2010 Return-Path: Delivered-To: net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1A913106564A for ; Wed, 10 Nov 2010 17:36:07 +0000 (UTC) (envelope-from bschmidt@techwires.net) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id CD88C8FC14 for ; Wed, 10 Nov 2010 17:36:06 +0000 (UTC) Received: by qwj8 with SMTP id 8so72621qwj.13 for ; Wed, 10 Nov 2010 09:36:06 -0800 (PST) MIME-Version: 1.0 Received: by 10.229.240.4 with SMTP id ky4mr7811515qcb.104.1289410565805; Wed, 10 Nov 2010 09:36:05 -0800 (PST) Sender: bschmidt@techwires.net Received: by 10.229.213.73 with HTTP; Wed, 10 Nov 2010 09:36:05 -0800 (PST) X-Originating-IP: [84.180.237.1] In-Reply-To: References: Date: Wed, 10 Nov 2010 18:36:05 +0100 X-Google-Sender-Auth: 2AdZU1-Hp3HqE99eUUd3tIpx2qc Message-ID: From: Bernhard Schmidt To: Paul B Mahol Content-Type: text/plain; charset=ISO-8859-1 Cc: net@freebsd.org Subject: Re: ndis: properly allocate memory X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Nov 2010 17:36:07 -0000 On Wed, Nov 10, 2010 at 15:56, Paul B Mahol wrote: > Hi, > > Attached patch resolves buggy allocation of memory in NDISulator. > Correct behavior is to not ignore parameters specified by miniport driver. The important point to mention here is that those restrictions are to be applied to physical memory according to specs for MmAllocateContiguousMemorySpecifyCache(), therefore the call to contigmalloc(). I'll take care of the commit. -- Bernhard